Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cbc6c947 authored by Arpan Kaphle's avatar Arpan Kaphle Committed by Automerger Merge Worker
Browse files

Merge "Cleaning up TODOs in Metric Classes" into udc-dev am: f7a33f14 am: 4361ce5c

parents fd6ce96d 4361ce5c
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ import java.util.Map;
/**
 * For all future metric additions, this will contain their names for local usage after importing
 * from {@link com.android.internal.util.FrameworkStatsLog}.
 * TODO(b/271135048) - Emit all atoms, including all V4 atoms (specifically the rest of track 1).
 */
public class MetricUtilities {
    private static final boolean LOG_FLAG = true;
+1 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ public class ProviderRegistryGetSession extends ProviderSession<CredentialOption
                .collect(Collectors.toList());
        updateStatusAndInvokeCallback(Status.CREDENTIALS_RECEIVED,
                /*source=*/ CredentialsSource.REGISTRY);
        // TODO(use metric later)
        // TODO(b/273353677) : metric should be emitted similarly to sibling classes
    }

    @Nullable
+1 −5
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ import java.util.stream.Collectors;
 * Some types are redundant across these metric collectors, but that has debug use-cases as
 * these data-types are available at different moments of the flow (and typically, one can feed
 * into the next).
 * TODO(b/270403549) - iterate on this in V3+
 */
public class CandidatePhaseMetric {

@@ -56,10 +55,7 @@ public class CandidatePhaseMetric {
    private int mProviderQueryStatus = -1;
    // Indicates if an exception was thrown by this provider, false by default
    private boolean mHasException = false;
    // Indicates the number of total entries available. We can also locally store the entries, but
    // cannot emit them in the current split form. TODO(b/271135048) - possibly readjust candidate
    // entries. Also, it may be okay to remove this and instead aggregate from inner counts.
    // Defaults to -1
    // Indicates the number of total entries available, defaults to -1
    private int mNumEntriesTotal = -1;
    // The count of action entries from this provider, defaults to -1
    private int mActionEntryCount = -1;
+0 −3
Original line number Diff line number Diff line
@@ -29,11 +29,8 @@ import java.util.List;
 * Some types are redundant across these metric collectors, but that has debug use-cases as
 * these data-types are available at different moments of the flow (and typically, one can feed
 * into the next).
 * TODO(b/270403549) - iterate on this in V3+
 */
public class ChosenProviderFinalPhaseMetric {

    // TODO(b/270403549) - applies elsewhere, likely removed or replaced w/ some hashed/count index
    private static final String TAG = "ChosenFinalPhaseMetric";
    // The session id associated with this API call, used to unite split emits
    private int mSessionId = -1;
+0 −2
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ import java.util.Map;
 * Some types are redundant across these metric collectors, but that has debug use-cases as
 * these data-types are available at different moments of the flow (and typically, one can feed
 * into the next).
 * TODO(b/270403549) - iterate on this in V3+
 */
public class InitialPhaseMetric {
    private static final String TAG = "InitialPhaseMetric";
@@ -47,7 +46,6 @@ public class InitialPhaseMetric {
    private long mCredentialServiceBeginQueryTimeNanoseconds = -1;

    // Indicates if the origin was specified when making this API request
    // TODO(b/271135048) - Emit once metrics approved
    private boolean mOriginSpecified = false;

    // Stores the deduped request information, particularly {"req":5}.
Loading