Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb250de6 authored by Robert Carr's avatar Robert Carr
Browse files

BLASTBufferQueue: Avoid unnecessary transactions 

Currently every call to getOrCreateBLASTSurface produces a transaction.
This transaction has two parts, both of which can be eliminated:
	1. The first is the reparent. This was written when the
	client allocated the BLAST SurfaceControl, but now the WM
	allocates it and it has the correct parent to start, so
	we can just eliminate this.
	2. Showing the surface. We can eliminate this by just showing
	the surface by default.

Bug: 152501055
Test: Flip BLAST flag. Play.
Change-Id: If6e28e9153a09909fb3bb061980deb82c132dd5a
parent b164ea9d

core/java/android/view/ViewRootImpl.java

+1 −4
Original line number Diff line number Diff line
@@ -1747,16 +1747,13 @@ public final class ViewRootImpl implements ViewParent, 
                || !mBlastSurfaceControl.isValid()) {

            return null;

        }



        if (mBlastBufferQueue == null) {

            mBlastBufferQueue = new BLASTBufferQueue(

                mBlastSurfaceControl, width, height);

        }

        mBlastBufferQueue.update(mBlastSurfaceControl, width, height);



        mTransaction.show(mBlastSurfaceControl)

            .reparent(mBlastSurfaceControl, mSurfaceControl)

            .apply();



        return mBlastBufferQueue.getSurface();

    }

services/core/java/com/android/server/wm/WindowSurfaceController.java

+1 −0
Original line number Diff line number Diff line
@@ -127,6 +127,7 @@ class WindowSurfaceController { 
            mBLASTSurfaceControl = win.makeSurface()

                .setParent(mSurfaceControl)

                .setName("BLAST Adapter Layer")

                .setHidden(false)

                .setBLASTLayer()

                .build();

        }