Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cafd5cd8 authored by Riddle Hsu's avatar Riddle Hsu Committed by Android (Google) Code Review
Browse files

Merge "Temporarily disable consecutive visibility assertion of close pip" into udc-dev

parents 2e423533 86d8cb8b
Loading
Loading
Loading
Loading
+0 −3
Original line number Diff line number Diff line
@@ -888,9 +888,6 @@ public class PipTransition extends PipTransitionController {
        // setting bounds.
        animator.setPipTransactionHandler(mTransactionConsumer).applySurfaceControlTransaction(
                leash, finishTransaction, PipAnimationController.FRACTION_END);
        // Remove the workaround after fixing ClosePipBySwipingDownTest that detects the shadow
        // as unexpected visible.
        finishTransaction.setShadowRadius(leash, 0);
        // Start to animate enter PiP.
        animator.setPipTransactionHandler(mPipOrganizer.getPipTransactionHandler()).start();
    }
+10 −0
Original line number Diff line number Diff line
@@ -95,4 +95,14 @@ open class ClosePipBySwipingDownTest(flicker: FlickerTest) : ClosePipTransition(
    fun focusDoesNotChange() {
        flicker.assertEventLog { this.focusDoesNotChange() }
    }

    @Test
    override fun visibleLayersShownMoreThanOneConsecutiveEntry() {
        // TODO(b/270678766): Enable the assertion after fixing the case:
        // Assume the PiP task has shadow.
        //  1. The PiP activity is visible -> Task is invisible because it is occluded by activity.
        //  2. Activity becomes invisible -> Task is visible because it has shadow.
        //  3. Task is moved outside screen -> Task becomes invisible.
        // The assertion is triggered for 2 that the Task is only visible in one frame.
    }
}