Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit caeabd30 authored by Remi NGUYEN VAN's avatar Remi NGUYEN VAN
Browse files

Use IPV6_MIN_MTU from NetworkConstants in Ikev2Vpn 

Instead of sharing the constant from LinkProperties, use the already
defined constant in the NetworkConstants class.

This allows Ikev2VpnProfile to allow depending on non-public
LinkProperties APIs, as LinkProperties is planned to move to
framework-connectivity.

Bug: 174436414
Test: m
Change-Id: I594bb7e81bc7681799c16eff621a5ffd1b29624c
parent 54082686

core/java/android/net/Ikev2VpnProfile.java

+5 −10
Original line number Diff line number Diff line
@@ -16,12 +16,9 @@ 


package android.net;



import static android.net.PlatformVpnProfile.TYPE_IKEV2_IPSEC_PSK;

import static android.net.PlatformVpnProfile.TYPE_IKEV2_IPSEC_RSA;

import static android.net.PlatformVpnProfile.TYPE_IKEV2_IPSEC_USER_PASS;



import static com.android.internal.annotations.VisibleForTesting.Visibility;

import static com.android.internal.util.Preconditions.checkStringNotEmpty;

import static com.android.net.module.util.NetworkStackConstants.IPV6_MIN_MTU;



import android.annotation.NonNull;

import android.annotation.Nullable;
@@ -158,9 +155,8 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile { 
        // IPv6 MTU is greater; since profiles may be started by the system on IPv4 and IPv6

        // networks, the VPN must provide a link fulfilling the stricter of the two conditions

        // (at least that of the IPv6 MTU).

        if (mMaxMtu < LinkProperties.MIN_MTU_V6) {

            throw new IllegalArgumentException(

                    "Max MTU must be at least" + LinkProperties.MIN_MTU_V6);

        if (mMaxMtu < IPV6_MIN_MTU) {

            throw new IllegalArgumentException("Max MTU must be at least" + IPV6_MIN_MTU);

        }



        switch (mType) {
@@ -811,9 +807,8 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile { 
            // IPv6 MTU is greater; since profiles may be started by the system on IPv4 and IPv6

            // networks, the VPN must provide a link fulfilling the stricter of the two conditions

            // (at least that of the IPv6 MTU).

            if (mtu < LinkProperties.MIN_MTU_V6) {

                throw new IllegalArgumentException(

                        "Max MTU must be at least " + LinkProperties.MIN_MTU_V6);

            if (mtu < IPV6_MIN_MTU) {

                throw new IllegalArgumentException("Max MTU must be at least " + IPV6_MIN_MTU);

            }

            mMaxMtu = mtu;

            return this;

core/java/android/net/LinkProperties.java

+1 −2
Original line number Diff line number Diff line
@@ -81,8 +81,7 @@ public final class LinkProperties implements Parcelable { 


    private static final int MIN_MTU    = 68;



    /** @hide */

    public static final int MIN_MTU_V6 = 1280;

    private static final int MIN_MTU_V6 = 1280;



    private static final int MAX_MTU    = 10000;