Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cacc6041 authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixed the divider height to be at least 1px high 

Also adapted the children divider to be consistent

Change-Id: I158167f70e9e0bc9e251785078a4b271720919c5
parent d35c2793

packages/SystemUI/res/layout/notification_children_divider.xml

+1 −1
Original line number Diff line number Diff line
@@ -19,5 +19,5 @@ 
    xmlns:android="http://schemas.android.com/apk/res/android"

    android:id="@+id/notification_more_divider"

    android:layout_width="match_parent"

    android:layout_height="@dimen/notification_children_divider_height"

    android:layout_height="@dimen/notification_divider_height"

    android:background="#61000000" />

packages/SystemUI/res/values/dimens.xml

+2 −8
Original line number Diff line number Diff line
@@ -87,9 +87,6 @@ 
    <!-- gap on either side of status bar notification icons -->

    <dimen name="status_bar_icon_padding">0dp</dimen>



    <!-- half the distance between notifications in the panel -->

    <dimen name="notification_divider_height">2dp</dimen>



    <!-- The padding on the global screenshot background image -->

    <dimen name="global_screenshot_bg_padding">20dp</dimen>
@@ -301,8 +298,8 @@ 
    <!-- Z distance between notifications if they are in the stack -->

    <dimen name="z_distance_between_notifications">1dp</dimen>



    <!-- The padding between the individual notification cards. -->

    <dimen name="notification_padding">0.5dp</dimen>

    <!-- The height of the divider between the individual notifications. -->

    <dimen name="notification_divider_height">0.5dp</dimen>



    <!-- The minimum amount of top overscroll to go to the quick settings. -->

    <dimen name="min_top_overscroll_to_qs">36dp</dimen>
@@ -372,9 +369,6 @@ 
    <!-- The padding on top of the first notification to the children container -->

    <dimen name="notification_children_container_top_padding">8dp</dimen>



    <!-- The height of the divider between the notfication children -->

    <dimen name="notification_children_divider_height">1dp</dimen>



    <!-- The vertical distance from which the notification appear when children are expanded -->

    <dimen name="notification_appear_distance">140dp</dimen>

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java

+2 −2
Original line number Diff line number Diff line
@@ -422,8 +422,8 @@ public class NotificationPanelView extends PanelView implements 
    public int computeMaxKeyguardNotifications(int maximum) {

        float minPadding = mClockPositionAlgorithm.getMinStackScrollerPadding(getHeight(),

                mKeyguardStatusView.getHeight());

        int notificationPadding = getResources().getDimensionPixelSize(

                R.dimen.notification_padding);

        int notificationPadding = Math.max(1, getResources().getDimensionPixelSize(

                R.dimen.notification_divider_height));

        final int overflowheight = getResources().getDimensionPixelSize(

                R.dimen.notification_summary_height);

        float bottomStackSize = mNotificationStackScroller.getKeyguardBottomStackSize();

packages/SystemUI/src/com/android/systemui/statusbar/stack/NotificationChildrenContainer.java

+2 −2
Original line number Diff line number Diff line
@@ -76,8 +76,8 @@ public class NotificationChildrenContainer extends ViewGroup { 
        super(context, attrs, defStyleAttr, defStyleRes);

        mChildPadding = getResources().getDimensionPixelSize(

                R.dimen.notification_children_padding);

        mDividerHeight = getResources().getDimensionPixelSize(

                R.dimen.notification_children_divider_height);

        mDividerHeight = Math.max(1, getResources().getDimensionPixelSize(

                R.dimen.notification_divider_height));

        mMaxNotificationHeight = getResources().getDimensionPixelSize(

                R.dimen.notification_max_height);

        mNotificationAppearDistance = getResources().getDimensionPixelSize(

packages/SystemUI/src/com/android/systemui/statusbar/stack/NotificationStackScrollLayout.java

+2 −2
Original line number Diff line number Diff line
@@ -367,8 +367,8 @@ public class NotificationStackScrollLayout extends ViewGroup 
        mBottomStackPeekSize = context.getResources()

                .getDimensionPixelSize(R.dimen.bottom_stack_peek_amount);

        mStackScrollAlgorithm.initView(context);

        mPaddingBetweenElementsNormal = context.getResources()

                .getDimensionPixelSize(R.dimen.notification_padding);

        mPaddingBetweenElementsNormal = Math.max(1, context.getResources()

                .getDimensionPixelSize(R.dimen.notification_divider_height));

        mPaddingBetweenElements = mPaddingBetweenElementsNormal;

        mBottomStackSlowDownHeight = mStackScrollAlgorithm.getBottomStackSlowDownLength();

        mMinTopOverScrollToEscape = getResources().getDimensionPixelSize(