Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit caad01b2 authored by Song Pan's avatar Song Pan
Browse files

Skip apk verification when collecting certificates. 

Bug: 154486093
Test: verified locally that this reduces 99% of the time taken to parse APK.
Change-Id: I6e1e5bc76c3e6b8e169c47847512b30aa1fe264e
parent 5d685f52

services/core/java/com/android/server/integrity/AppIntegrityManagerServiceImpl.java

+6 −3
Original line number Diff line number Diff line
@@ -568,7 +568,10 @@ public class AppIntegrityManagerServiceImpl extends IAppIntegrityManager.Stub { 
        try (PackageParser2 parser = mParserSupplier.get()) {

            ParsedPackage pkg = parser.parsePackage(installationPath, 0, false);

            int flags = PackageManager.GET_SIGNING_CERTIFICATES | PackageManager.GET_META_DATA;

            pkg.setSigningDetails(ParsingPackageUtils.collectCertificates(pkg, false));

            // APK signatures is already verified elsewhere in PackageManager. We do not need to

            // verify it again since it could cause a timeout for large APKs.

            pkg.setSigningDetails(

                    ParsingPackageUtils.collectCertificates(pkg, /* skipVerify= */ true));

            return PackageInfoUtils.generate(

                    pkg,

                    null,