Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca4d8422 authored by Todd Kennedy's avatar Todd Kennedy
Browse files

Rename the binder call createActivityContainer 

Change the call to createVirtualActivityContainer to better describe what's
actually being created with the call.

Change-Id: Id3a32df19a5bb6740cbabcd65897349e9f2f2946
parent 2c4b1610

cmds/am/src/com/android/commands/am/Am.java

+2 −1
Original line number Diff line number Diff line
@@ -1695,7 +1695,8 @@ public class Am extends BaseCommand { 


        try {

            IBinder homeActivityToken = mAm.getHomeActivityToken();

            IActivityContainer container = mAm.createActivityContainer(homeActivityToken, null);

            IActivityContainer container =

                    mAm.createVirtualActivityContainer(homeActivityToken, null);

            container.attachToDisplay(displayId);

            container.startActivity(intent);

        } catch (RemoteException e) {

core/java/android/app/ActivityManagerNative.java

+4 −4
Original line number Diff line number Diff line
@@ -2183,13 +2183,13 @@ public abstract class ActivityManagerNative extends Binder implements IActivityM 
            return true;

        }



        case CREATE_ACTIVITY_CONTAINER_TRANSACTION: {

        case CREATE_VIRTUAL_ACTIVITY_CONTAINER_TRANSACTION: {

            data.enforceInterface(IActivityManager.descriptor);

            IBinder parentActivityToken = data.readStrongBinder();

            IActivityContainerCallback callback =

                    IActivityContainerCallback.Stub.asInterface(data.readStrongBinder());

            IActivityContainer activityContainer =

                    createActivityContainer(parentActivityToken, callback);

                    createVirtualActivityContainer(parentActivityToken, callback);

            reply.writeNoException();

            if (activityContainer != null) {

                reply.writeInt(1);
@@ -5205,14 +5205,14 @@ class ActivityManagerProxy implements IActivityManager 
        reply.recycle();

    }



    public IActivityContainer createActivityContainer(IBinder parentActivityToken,

    public IActivityContainer createVirtualActivityContainer(IBinder parentActivityToken,

            IActivityContainerCallback callback) throws RemoteException {

        Parcel data = Parcel.obtain();

        Parcel reply = Parcel.obtain();

        data.writeInterfaceToken(IActivityManager.descriptor);

        data.writeStrongBinder(parentActivityToken);

        data.writeStrongBinder(callback == null ? null : callback.asBinder());

        mRemote.transact(CREATE_ACTIVITY_CONTAINER_TRANSACTION, data, reply, 0);

        mRemote.transact(CREATE_VIRTUAL_ACTIVITY_CONTAINER_TRANSACTION, data, reply, 0);

        reply.readException();

        final int result = reply.readInt();

        final IActivityContainer res;

core/java/android/app/ActivityView.java

+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ public class ActivityView extends ViewGroup { 


        try {

            mActivityContainer = new ActivityContainerWrapper(

                    ActivityManagerNative.getDefault().createActivityContainer(

                    ActivityManagerNative.getDefault().createVirtualActivityContainer(

                            mActivity.getActivityToken(), new ActivityContainerCallback(this)));

        } catch (RemoteException e) {

            throw new RuntimeException("ActivityView: Unable to create ActivityContainer. "

core/java/android/app/IActivityManager.java

+2 −2
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ public interface IActivityManager extends IInterface { 


    public void performIdleMaintenance() throws RemoteException;



    public IActivityContainer createActivityContainer(IBinder parentActivityToken,

    public IActivityContainer createVirtualActivityContainer(IBinder parentActivityToken,

            IActivityContainerCallback callback) throws RemoteException;



    public void deleteActivityContainer(IActivityContainer container) throws RemoteException;
@@ -737,7 +737,7 @@ public interface IActivityManager extends IInterface { 
    int KILL_UID_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+164;

    int SET_USER_IS_MONKEY_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+165;

    int HANG_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+166;

    int CREATE_ACTIVITY_CONTAINER_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+167;

    int CREATE_VIRTUAL_ACTIVITY_CONTAINER_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+167;

    int MOVE_TASK_TO_STACK_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+168;

    int RESIZE_STACK_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+169;

    int GET_ALL_STACK_INFOS_TRANSACTION = IBinder.FIRST_CALL_TRANSACTION+170;

services/core/java/com/android/server/am/ActivityManagerService.java

+2 −2
Original line number Diff line number Diff line
@@ -8604,7 +8604,7 @@ public final class ActivityManagerService extends ActivityManagerNative 
    }















    @Override













    public IActivityContainer createActivityContainer(IBinder parentActivityToken,













    public IActivityContainer createVirtualActivityContainer(IBinder parentActivityToken,















            IActivityContainerCallback callback) throws RemoteException {















        enforceCallingPermission(android.Manifest.permission.MANAGE_ACTIVITY_STACKS,















                "createActivityContainer()");









@@ -8619,7 +8619,7 @@ public final class ActivityManagerService extends ActivityManagerNative













            if (callback == null) {















                throw new IllegalArgumentException("callback must not be null");















            }













            return mStackSupervisor.createActivityContainer(r, callback);













            return mStackSupervisor.createVirtualActivityContainer(r, callback);















        }















    }