Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9e16e63 authored by Chris Göllner's avatar Chris Göllner
Browse files

Fix duplicate dagger binding of MediaProjectionAppSelectorActivity 

It was bound twice:
1 - Constructor injection
2 - Subcomponent `@BindsInstance`

Fixes: 292682275
Test: Build & Run
Change-Id: I8676153b99a32bd06b3978444f4cde4b04193d90
parent 9958309d

packages/SystemUI/src/com/android/systemui/media/MediaProjectionAppSelectorActivity.kt

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ class MediaProjectionAppSelectorActivity( 


    public override fun onCreate(bundle: Bundle?) {

        lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_CREATE)

        component = componentFactory.create(activity = this, view = this, resultHandler = this)

        component = componentFactory.create(view = this, resultHandler = this)

        component.lifecycleObservers.forEach { lifecycle.addObserver(it) }



        // Create a separate configuration controller for this activity as the configuration

packages/SystemUI/src/com/android/systemui/mediaprojection/appselector/MediaProjectionAppSelectorComponent.kt

+0 −1
Original line number Diff line number Diff line
@@ -161,7 +161,6 @@ interface MediaProjectionAppSelectorComponent { 
    interface Factory {

        /** Create a factory to inject the activity into the graph */

        fun create(

            @BindsInstance activity: MediaProjectionAppSelectorActivity,

            @BindsInstance view: MediaProjectionAppSelectorView,

            @BindsInstance resultHandler: MediaProjectionAppSelectorResultHandler,

        ): MediaProjectionAppSelectorComponent