Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c93643be authored by Steve Block's avatar Steve Block
Browse files

Remove some stale TODOs from the Java Bridge tests 

These TODOs were related to testing behavior with JavaScript and Java arrays.
This is now tested thoroughly in JavaBridgeArrayTest.java and
JavaBridgeArrayCoercionTest.java.

No functional change.

Change-Id: I5972b929c3e2743c06aff626c983b4b749ea452f
parent 38e90751

tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java

+0 −5
Original line number Diff line number Diff line
@@ -47,7 +47,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { 
        private long mLongValue;

        private float mFloatValue;

        private double mDoubleValue;

        // TODO: Test passing to methods with array parameters.

        private String mStringValue;

        private Object mObjectValue;

        private CustomType mCustomTypeValue;
@@ -100,7 +99,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { 
            mDoubleValue = x;

            notifyResultIsReady();

        }

        // TODO: Test passing to methods with array parameters.

        public synchronized void setStringValue(String x) {

            mStringValue = x;

            notifyResultIsReady();
@@ -146,7 +144,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { 
            waitForResult();

            return mDoubleValue;

        }

        // TODO: Test passing to methods with array parameters.

        public synchronized String waitForStringValue() {

            waitForResult();

            return mStringValue;
@@ -472,8 +469,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { 
        assertNull(mTestObject.waitForCustomTypeValue());

    }



    // TODO: Test passing arrays.



    // Test passing a JavaScript object to a method of an injected object.

    public void testPassJavaScriptObject() throws Throwable {

        // LIVECONNECT_COMPLIANCE: Should raise a JavaScript exception.