Refuse update of a system app if it changes its shared uid (c935d1f1) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/pm/PackageManagerService.java

+13 −2

Original line number	Diff line number	Diff line
		@@ -9214,10 +9214,21 @@ public class PackageManagerService extends IPackageManager.Stub {
		final PackageSetting newPkgSetting = (PackageSetting)newPackage.mExtras;
		newPkgSetting.firstInstallTime = oldPkgSetting.firstInstallTime;
		newPkgSetting.lastUpdateTime = System.currentTimeMillis();

		// is the update attempting to change shared user? that isn't going to work...
		if (oldPkgSetting.sharedUser != newPkgSetting.sharedUser) {
		Slog.w(TAG, "Forbidding shared user change from " + oldPkgSetting.sharedUser
		+ " to " + newPkgSetting.sharedUser);
		res.returnCode = PackageManager.INSTALL_FAILED_SHARED_USER_INCOMPATIBLE;
		updatedSettings = true;
		}
		}

		if (res.returnCode == PackageManager.INSTALL_SUCCEEDED) {
		updateSettingsLI(newPackage, installerPackageName, allUsers, perUserInstalled, res);
		updatedSettings = true;
		}
		}

		if (res.returnCode != PackageManager.INSTALL_SUCCEEDED) {
		// Re installation failed. Restore old information