Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c92adae8 authored by Michael Wright's avatar Michael Wright
Browse files

Fix formatting string in PolicyVersionUpgrade 

The format string had an extra '%s' which was presumably for the
Exception string, but Slog.e already captures that.

Bug: 217923092
Test: errorprone build
Change-Id: I523bd94b65f00bc0332a2c3e3c8ed28de2df1974
parent 400ea882

services/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ java_defaults { 
            "-Xep:NullTernary:ERROR",

            "-Xep:TryFailThrowable:ERROR",

            "-Xep:HashtableContains:ERROR",

            "-Xep:FormatString:ERROR",

            // NOTE: only enable to generate local patchfiles

            // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",

            // "-XepPatchLocation:/tmp/refaster/",

services/devicepolicy/java/com/android/server/devicepolicy/PolicyVersionUpgrader.java

+1 −1
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ public class PolicyVersionUpgrader { 
            Files.write(file.toPath(), versionBytes);

            versionFile.commit();

        } catch (IOException e) {

            Slog.e(LOG_TAG, String.format("Writing version %d failed: %s", version), e);

            Slog.e(LOG_TAG, String.format("Writing version %d failed", version), e);

            versionFile.rollback();

        }

    }