Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c90b7b5d authored by Vlad Popa's avatar Vlad Popa
Browse files

CTA2075: remove the release method 

Using the close method instead from the AutoCloseable inheritance

Test: atest LoudnessCodecControllerTest
Bug: 321949441
Change-Id: Ie30c0cc5ea5704ded37579f89566648076a3b339
parent c121002a

core/api/current.txt

+1 −2
Original line number Diff line number Diff line
@@ -22195,11 +22195,10 @@ package android.media { 














  @FlaggedApi("android.media.audio.loudness_configurator_api") public class LoudnessCodecController implements java.lang.AutoCloseable {















    method @FlaggedApi("android.media.audio.loudness_configurator_api") public boolean addMediaCodec(@NonNull android.media.MediaCodec);













    method public void close();













    method @FlaggedApi("android.media.audio.loudness_configurator_api") public void close();















    method @FlaggedApi("android.media.audio.loudness_configurator_api") @NonNull public static android.media.LoudnessCodecController create(int);















    method @FlaggedApi("android.media.audio.loudness_configurator_api") @NonNull public static android.media.LoudnessCodecController create(int, @NonNull java.util.concurrent.Executor, @NonNull android.media.LoudnessCodecController.OnLoudnessCodecUpdateListener);















    method @FlaggedApi("android.media.audio.loudness_configurator_api") @NonNull public android.os.Bundle getLoudnessCodecParams(@NonNull android.media.MediaCodec);













    method @FlaggedApi("android.media.audio.loudness_configurator_api") public void release();















    method @FlaggedApi("android.media.audio.loudness_configurator_api") public void removeMediaCodec(@NonNull android.media.MediaCodec);















  }







































media/java/android/media/LoudnessCodecController.java



+0
−5




























Original line number
Diff line number
Diff line








@@ -320,11 +320,6 @@ public class LoudnessCodecController implements SafeCloseable {













     * Stops any loudness updates and frees up the resources.















     */















    @FlaggedApi(FLAG_LOUDNESS_CONFIGURATOR_API)













    public void release() {













        close();













    }



























    /** @hide */















    @Override















    public void close() {















        synchronized (mControllerLock) {

































media/tests/LoudnessCodecApiTest/src/com/android/loudnesscodecapitest/LoudnessCodecControllerTest.java



+1
−1




























Original line number
Diff line number
Diff line








@@ -126,7 +126,7 @@ public class LoudnessCodecControllerTest {





























        try {















            mLcc.addMediaCodec(mediaCodec);













            mLcc.release();  // stops updats













            mLcc.close();  // stops updates































            verify(mAudioService).stopLoudnessCodecUpdates(eq(mSessionId));















        } finally {