Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c905f6dd authored by Ibrahim Yilmaz's avatar Ibrahim Yilmaz Committed by Android Build Coastguard Worker
Browse files

Remove spammy height update logs 

Height update logs are very spammy and make debugging very hard. This CL removes these logs but they can be added back differently.

Bug: 424163539
Flag: EXEMPT log cleaning
Test: Presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:64d4a390ff229ee1c95d8243c41d9a528408426f)
Merged-In: Ic211d694347a3ca6135ced720aceaf417d7b6e90
Change-Id: Ic211d694347a3ca6135ced720aceaf417d7b6e90
parent 6604dcdc

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java

+9 −3
Original line number Diff line number Diff line
@@ -4702,9 +4702,8 @@ public class NotificationStackScrollLayout 
        ExpandableView firstVisibleChild =

                firstSection == null ? null : firstSection.getFirstVisibleChild();

        if (row != null) {

            if (mLogger != null) {

                mLogger.childHeightUpdated(row, needsAnimation);

            }

            // TODO(b/424163539): child height updated logs are spammy, which hides other logs

            // logChildHeightUpdated(row, needsAnimation);

            if (row == firstVisibleChild

                    || row.getNotificationParent() == firstVisibleChild) {

                updateAlgorithmLayoutMinHeight();
@@ -4718,6 +4717,13 @@ public class NotificationStackScrollLayout 
        mAnimateStackYForContentHeightChange = previouslyNeededAnimation;

    }





    private void logChildHeightUpdated(ExpandableNotificationRow row, boolean needsAnimation) {

        if (mLogger != null) {

            mLogger.childHeightUpdated(row, needsAnimation);

        }

    }



    void onChildHeightReset(ExpandableView view) {

        updateAnimationState(view);

        updateChronometerForChild(view);

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/domain/interactor/SharedNotificationContainerInteractor.kt

+2 −1
Original line number Diff line number Diff line
@@ -138,7 +138,8 @@ constructor( 


    /** An internal modification was made to notifications */

    fun notificationStackChanged() {

        logger?.notificationStackChanged()

        // TODO(b/424163539): child height updated logs are spammy, which hides other logs

        // logger?.notificationStackChanged()

        notificationStackChangedDebounced.value = notificationStackChangedDebounced.value + 1

    }