Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8c798bb authored by Charles Chen's avatar Charles Chen
Browse files

Dump log when trying to launch overlay from split 

... to notify users.

Test: none
Bug: 353947605
Flag: EXEMPT add logs
Change-Id: I1590fdec2f17d2493c31fedfc48a6adf046975b2
parent ad9cfa87

libs/WindowManager/Jetpack/src/androidx/window/extensions/embedding/SplitController.java

+5 −1
Original line number Diff line number Diff line
@@ -2713,15 +2713,19 @@ public class SplitController implements JetpackTaskFragmentOrganizer.TaskFragmen 
    TaskFragmentContainer createOrUpdateOverlayTaskFragmentIfNeeded(

            @NonNull WindowContainerTransaction wct, @NonNull Bundle options,

            @NonNull Intent intent, @NonNull Activity launchActivity) {

        final String overlayTag = Objects.requireNonNull(options.getString(KEY_OVERLAY_TAG));

        if (isActivityFromSplit(launchActivity)) {

            // We restrict to launch the overlay from split. Fallback to treat it as normal

            // launch.

            Log.w(TAG, "It's not allowed to launch overlay container with tag=" + overlayTag

                    + " from activity in Activity Embedding split."

                    + " Launching activity=" + launchActivity

                    + " Fallback to launch the activity as normal launch.");

            return null;

        }



        final List<TaskFragmentContainer> overlayContainers =

                getAllNonFinishingOverlayContainers();

        final String overlayTag = Objects.requireNonNull(options.getString(KEY_OVERLAY_TAG));

        final boolean associateLaunchingActivity = options

                .getBoolean(KEY_OVERLAY_ASSOCIATE_WITH_LAUNCHING_ACTIVITY, true);