Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8bfc68c authored by Alan Viverette's avatar Alan Viverette
Browse files

Only resize list popup if it's still attached to a window 

We can't rely on ListPopupWindow.dismiss() to get called before the popup
is removed, for example when the activity hosting the popup is finished,
but we can easily ensure that the popup is still attached to a window.

Bug: 20831507
Change-Id: I9dcaa46e68df3f2b301cf299fa64d460c7e177fd
parent 83ce3b26

core/java/android/widget/ListPopupWindow.java

+3 −2
Original line number Diff line number Diff line
@@ -1791,8 +1791,9 @@ public class ListPopupWindow { 


    private class ResizePopupRunnable implements Runnable {

        public void run() {

            if (mDropDownList != null && mDropDownList.getCount() > mDropDownList.getChildCount() &&

                    mDropDownList.getChildCount() <= mListItemExpandMaximum) {

            if (mDropDownList != null && mDropDownList.isAttachedToWindow()

                    && mDropDownList.getCount() > mDropDownList.getChildCount()

                    && mDropDownList.getChildCount() <= mListItemExpandMaximum) {

                mPopup.setInputMethodMode(PopupWindow.INPUT_METHOD_NOT_NEEDED);

                show();

            }