Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8aec5f1 authored by Chiachang Wang's avatar Chiachang Wang Committed by Automerger Merge Worker
Browse files

Merge "Only set excludeLocalRoutes in the bypassable VpnProfile" am:...

Merge "Only set excludeLocalRoutes in the bypassable VpnProfile" am: b70a0862 am: bfc4c06f am: f1f4773f am: 8f7da779

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1944537

Change-Id: I224709966a9ae453c90f3f40e391ab8c844ec708
parents dd9d854f 8f7da779
Loading
Loading
Loading
Loading
+6 −1
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ import android.annotation.Nullable;
import android.annotation.RequiresFeature;
import android.content.pm.PackageManager;
import android.security.Credentials;
import android.util.Log;

import com.android.internal.annotations.VisibleForTesting;
import com.android.internal.net.VpnProfile;
@@ -70,6 +71,7 @@ import java.util.Objects;
 *     Exchange, Version 2 (IKEv2)</a>
 */
public final class Ikev2VpnProfile extends PlatformVpnProfile {
    private static final String TAG = Ikev2VpnProfile.class.getSimpleName();
    /** Prefix for when a Private Key is an alias to look for in KeyStore @hide */
    public static final String PREFIX_KEYSTORE_ALIAS = "KEYSTORE_ALIAS:";
    /** Prefix for when a Private Key is stored directly in the profile @hide */
@@ -524,7 +526,10 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile {
                throw new IllegalArgumentException("Invalid auth method set");
        }

        builder.setExcludeLocalRoutes(profile.excludeLocalRoutes);
        if (profile.excludeLocalRoutes && !profile.isBypassable) {
            Log.w(TAG, "ExcludeLocalRoutes should only be set in the bypassable VPN");
        }
        builder.setExcludeLocalRoutes(profile.excludeLocalRoutes && profile.isBypassable);

        return builder.build();
    }