Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c796ad0a authored by Yusuke Sato's avatar Yusuke Sato
Browse files

Clean up AssetManager::scanAndMergeZipLocked 

Now that ZipFileRO::startIteration supports prefix/suffix matching,
we can pass dirName to the function for simpler code and slightly
better performance.

Change-Id: Ia93c3ab3fa688ce013dd9febbf0f4bd3ee1f3e5e
parent 1b11146b

libs/androidfw/AssetManager.cpp

+2 −4
Original line number Diff line number Diff line
@@ -1545,7 +1545,7 @@ bool AssetManager::scanAndMergeZipLocked(SortedVector<AssetDir::FileInfo>* pMerg 
     */

    int dirNameLen = dirName.length();

    void *iterationCookie;

    if (!pZip->startIteration(&iterationCookie)) {

    if (!pZip->startIteration(&iterationCookie, dirName.string(), NULL)) {

        ALOGW("ZipFileRO::startIteration returned false");

        return false;

    }
@@ -1560,9 +1560,7 @@ bool AssetManager::scanAndMergeZipLocked(SortedVector<AssetDir::FileInfo>* pMerg 
            continue;

        }

        //printf("Comparing %s in %s?\n", nameBuf, dirName.string());

        if (dirNameLen == 0 ||

            (strncmp(nameBuf, dirName.string(), dirNameLen) == 0 &&

             nameBuf[dirNameLen] == '/'))

        if (dirNameLen == 0 || nameBuf[dirNameLen] == '/')

        {

            const char* cp;

            const char* nextSlash;