Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c75ec332 authored Dec 17, 2010 by Chet Haase

Fix for TimePicker not redrawing itself.

The problem was that NumberPicker override View.draw(), but did not
call the superclass version of the method in some situations. This
resulted in the DIRTY flag for the view not getting cleared properly,
and future invalidations not propagating correctly.

The fix was to call super.draw() from NumberPicker.draw().

Change-Id: Ic17215dea86d54b77375494ada124dd6970e3ad6

parent d3040307

core/java/android/view/View.java

+3 −2

Original line number	Diff line number	Diff line
		@@ -8206,8 +8206,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback, Accessibility
		/**
		* Manually render this view (and all of its children) to the given Canvas.
		* The view must have already done a full layout before this function is
		* called. When implementing a view, do not override this method; instead,
		* you should implement {@link #onDraw}.
		* called. When implementing a view, implement {@link #onDraw} instead of
		* overriding this method. If you do need to override this method, call
		* the superclass version.
		*
		* @param canvas The Canvas to which the View is rendered.
		*/

core/java/android/widget/NumberPicker.java

+1 −4

Original line number	Diff line number	Diff line
		@@ -979,10 +979,7 @@ public class NumberPicker extends LinearLayout {
		// children
		// after we have completed drawing ourselves.

		// Draw the selector wheel if needed
		if (mDrawSelectorWheel) {
		super.draw(canvas);
		}

		// Draw our children if we are not showing the selector wheel of fading
		// it out