Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c683d2ae authored by John Reck's avatar John Reck
Browse files

Add back checkThread for invalidate() call 

This would have helped with debugging some SyncBarrier
issues. The camera issue seems to have been fixed,
but flagging means a slow rollout to be sure anyway.

Test: build & boot
Bug: 333752000
Change-Id: I608c2db4931e324dee018ba84310a69a3f5f6709
parent 97a77117

core/java/android/view/ViewRootImpl.java

+7 −3
Original line number Diff line number Diff line
@@ -234,6 +234,7 @@ import android.view.animation.Interpolator; 
import android.view.autofill.AutofillManager;

import android.view.contentcapture.ContentCaptureManager;

import android.view.contentcapture.ContentCaptureSession;

import android.view.flags.Flags;

import android.view.inputmethod.ImeTracker;

import android.view.inputmethod.InputMethodManager;

import android.widget.Scroller;
@@ -1156,7 +1157,9 @@ public final class ViewRootImpl implements ViewParent, 
    private static boolean sToolkitFrameRateTypingReadOnlyFlagValue;

    private static final boolean sToolkitFrameRateViewEnablingReadOnlyFlagValue;

    private static boolean sToolkitFrameRateVelocityMappingReadOnlyFlagValue =

            toolkitFrameRateVelocityMappingReadOnly();;

            toolkitFrameRateVelocityMappingReadOnly();

    private static boolean sToolkitEnableInvalidateCheckThreadFlagValue =

            Flags.enableInvalidateCheckThread();















    static {















        sToolkitSetFrameRateReadOnlyFlagValue = toolkitSetFrameRateReadOnly();










@@ -2378,8 +2381,9 @@ public final class ViewRootImpl implements ViewParent,



























    @Override















    public void onDescendantInvalidated(@NonNull View child, @NonNull View descendant) {













        // TODO: Re-enable after camera is fixed or consider targetSdk checking this













        // checkThread();













        if (sToolkitEnableInvalidateCheckThreadFlagValue) {













            checkThread();













        }















        if ((descendant.mPrivateFlags & PFLAG_DRAW_ANIMATION) != 0) {















            mIsAnimating = true;















        }

































core/java/android/view/flags/view_flags.aconfig



+8
−0




























Original line number
Diff line number
Diff line








@@ -50,3 +50,11 @@ flag {













    description: "Enable default arrow icon when hovering on buttons or clickable widgets."















    bug: "299269803"















}



























flag {













    name: "enable_invalidate_check_thread"













    namespace: "toolkit"













    description: "Enable checkThread call in ViewRootImpl#onDescendentInvalidated"













    bug: "333752000"













    is_fixed_read_only: true













}