Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c65ffb8f authored by wilsonshih's avatar wilsonshih
Browse files

Remove flag exclude_drawing_app_theme_snapshot_from_lock 

Bug: 409612732
Flag: EXEMPT flag removal
Test: presubmit
Change-Id: I608a8077d9044ae714dc1f852542407c31dcaafb
parent 7e8e08a4

core/java/android/window/flags/windowing_frontend.aconfig

+0 −11
Original line number Original line Diff line number Diff line
@@ -416,17 +416,6 @@ flag { 
  is_fixed_read_only: true

  is_fixed_read_only: true

}

}





flag {

    name: "exclude_drawing_app_theme_snapshot_from_lock"

    namespace: "windowing_frontend"

    description: "Do not hold wm lock when drawing app theme snapshot."

    is_fixed_read_only: true

    bug: "373502791"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

flag {

    name: "reduce_changed_exclusion_rects_msgs"

    name: "reduce_changed_exclusion_rects_msgs"

    namespace: "windowing_frontend"

    namespace: "windowing_frontend"

services/core/java/com/android/server/wm/AbsAppSnapshotController.java

+2 −8
Original line number Original line Diff line number Diff line
@@ -165,15 +165,9 @@ abstract class AbsAppSnapshotController<TYPE extends WindowContainer, 
        switch (getSnapshotMode(source)) {

        switch (getSnapshotMode(source)) {

            case SNAPSHOT_MODE_APP_THEME:

            case SNAPSHOT_MODE_APP_THEME:

                Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "drawAppThemeSnapshot");

                Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "drawAppThemeSnapshot");

                if (Flags.excludeDrawingAppThemeSnapshotFromLock()) {

                if (allowAppTheme) {

                if (allowAppTheme) {

                    supplier.setSupplier(drawAppThemeSnapshot(source));

                    supplier.setSupplier(drawAppThemeSnapshot(source));

                }

                }

                } else {

                    final Supplier<TaskSnapshot> original = drawAppThemeSnapshot(source);

                    final TaskSnapshot snapshot = original != null ? original.get() : null;

                    supplier.setSnapshot(snapshot);

                }

                Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

                Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

                break;

                break;

            case SNAPSHOT_MODE_REAL:

            case SNAPSHOT_MODE_REAL:

services/core/java/com/android/server/wm/TaskSnapshotController.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -34,7 +34,6 @@ import android.window.TaskSnapshot; 




import com.android.server.policy.WindowManagerPolicy.ScreenOffListener;

import com.android.server.policy.WindowManagerPolicy.ScreenOffListener;

import com.android.server.wm.BaseAppSnapshotPersister.PersistInfoProvider;

import com.android.server.wm.BaseAppSnapshotPersister.PersistInfoProvider;

import com.android.window.flags.Flags;





import java.util.ArrayList;

import java.util.ArrayList;
@@ -140,7 +139,7 @@ class TaskSnapshotController extends AbsAppSnapshotController<Task, TaskSnapshot 
            return;

            return;

        }

        }

        final int mode = getSnapshotMode(task);

        final int mode = getSnapshotMode(task);

        if (Flags.excludeDrawingAppThemeSnapshotFromLock() && mode == SNAPSHOT_MODE_APP_THEME) {

        if (mode == SNAPSHOT_MODE_APP_THEME) {

            mService.mH.post(supplier::handleSnapshot);

            mService.mH.post(supplier::handleSnapshot);

        } else {

        } else {

            supplier.handleSnapshot();

            supplier.handleSnapshot();

services/tests/wmtests/src/com/android/server/wm/TaskSnapshotControllerTest.java

+0 −4
Original line number Original line Diff line number Diff line
@@ -46,14 +46,11 @@ import android.graphics.PixelFormat; 
import android.graphics.Point;

import android.graphics.Point;

import android.graphics.Rect;

import android.graphics.Rect;

import android.hardware.HardwareBuffer;

import android.hardware.HardwareBuffer;

import android.platform.test.annotations.EnableFlags;

import android.platform.test.annotations.Presubmit;

import android.platform.test.annotations.Presubmit;

import android.window.TaskSnapshot;

import android.window.TaskSnapshot;





import androidx.test.filters.SmallTest;

import androidx.test.filters.SmallTest;





import com.android.window.flags.Flags;



import org.junit.Test;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.junit.runner.RunWith;

import org.mockito.Mockito;

import org.mockito.Mockito;
@@ -229,7 +226,6 @@ public class TaskSnapshotControllerTest extends WindowTestsBase { 
    }

    }





    @Test

    @Test

    @EnableFlags(Flags.FLAG_EXCLUDE_DRAWING_APP_THEME_SNAPSHOT_FROM_LOCK)

    public void testRecordTaskSnapshot() {

    public void testRecordTaskSnapshot() {

        spyOn(mWm.mTaskSnapshotController.mCache);

        spyOn(mWm.mTaskSnapshotController.mCache);

        spyOn(mWm.mTaskSnapshotController);

        spyOn(mWm.mTaskSnapshotController);