Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c626fcc9 authored by Jiaming Cheng's avatar Jiaming Cheng
Browse files

[QSDetailedView] Add a11y labels for internet details 

Make the entire wifi/mobile-data switch entry togglable.

Bug: 414666970
Flag: com.android.systemui.qs_tile_detailed_view
Test: Only add a11y label. Existing unit tests still pass.
Change-Id: Iabcf64362b737f09656455983e7fac4d75bd9dc6
parent 6ee96f4e

packages/SystemUI/res/layout/internet_connectivity_details.xml

+0 −2
Original line number Diff line number Diff line
@@ -353,7 +353,6 @@ 


                    <ImageView

                        android:id="@+id/arrow_forward"

                        android:contentDescription="@string/see_all_networks"

                        android:layout_width="wrap_content"

                        android:layout_height="wrap_content"

                        android:layout_gravity="center"
@@ -542,7 +541,6 @@ 
                        android:clickable="false">



                        <ImageView

                            android:contentDescription="@string/share_wifi_button_text"

                            android:src="@drawable/ic_screenshot_share"

                            android:layout_width="wrap_content"

                            android:layout_height="wrap_content"

packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDetailsContentManager.kt

+7 −5
Original line number Diff line number Diff line
@@ -346,7 +346,8 @@ constructor( 
        seeAllLayout = contentView.requireViewById(R.id.see_all_layout)



        // Set click listeners for Wi-Fi related views

        wifiToggle.setOnClickListener {

        turnWifiOnLayout.setOnClickListener {

            wifiToggle.toggle()

            val isChecked = wifiToggle.isChecked

            handleWifiToggleClicked(isChecked)

        }
@@ -376,8 +377,9 @@ constructor( 
            internetDetailsContentController.connectCarrierNetwork()

        }



        // Mobile data toggle

        mobileDataToggle.setOnClickListener {

        // Mobile data toggle entry

        turnMobileOnLayout.setOnClickListener {

            mobileDataToggle.toggle()

            val isChecked = mobileDataToggle.isChecked

            if (!isChecked && shouldShowMobileDialog()) {

                mobileDataToggle.isChecked = true
@@ -885,8 +887,8 @@ constructor( 
        connectedWifiListLayout.setOnClickListener(null)

        secondaryMobileNetworkLayout?.setOnClickListener(null)

        seeAllLayout.setOnClickListener(null)

        wifiToggle.setOnCheckedChangeListener(null)

        mobileDataToggle.setOnCheckedChangeListener(null)

        turnWifiOnLayout.setOnClickListener(null)

        turnMobileOnLayout.setOnClickListener(null)

        shareWifiButton.setOnClickListener(null)

        addNetworkButton.setOnClickListener(null)

        airplaneModeButton.setOnClickListener(null)