Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c61dc92f authored by Hugo Benichi's avatar Hugo Benichi
Browse files

Instrument captive portal login activity 

Also add CAPTIVE_PORTAL_LOGIN_ACTIVITY_SSL_ERROR constants to
metrics_constants.proto for counting ssl error pages shown by the
captive portal login activity.

Bug: 36203355
Bug: 34901696
Bug: 36532213
Test: manually tested with captive portal testing setup while watching
      event logs: adb logcat -b events | grep captiveportallogin
        06-08 16:25:20.279 21558 21558 I sysui_action: [1004,com.android.captiveportallogin]
        06-08 17:01:04.052 21558 21558 I sysui_action: [1007,com.android.captiveportallogin]

Change-Id: Ia05853506d424ad4cb2c11770ae7718fbef3f01c
parent c49b4840

packages/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java

+20 −1
Original line number Diff line number Diff line
@@ -47,6 +47,9 @@ import android.webkit.WebViewClient; 
import android.widget.ProgressBar;

import android.widget.TextView;



import com.android.internal.logging.MetricsLogger;

import com.android.internal.logging.nano.MetricsProto.MetricsEvent;



import java.io.IOException;

import java.net.HttpURLConnection;

import java.net.MalformedURLException;
@@ -63,7 +66,14 @@ public class CaptivePortalLoginActivity extends Activity { 


    private static final int SOCKET_TIMEOUT_MS = 10000;



    private enum Result { DISMISSED, UNWANTED, WANTED_AS_IS };

    private enum Result {

        DISMISSED(MetricsEvent.ACTION_CAPTIVE_PORTAL_LOGIN_RESULT_DISMISSED),

        UNWANTED(MetricsEvent.ACTION_CAPTIVE_PORTAL_LOGIN_RESULT_UNWANTED),

        WANTED_AS_IS(MetricsEvent.ACTION_CAPTIVE_PORTAL_LOGIN_RESULT_WANTED_AS_IS);



        final int metricsEvent;

        Result(int metricsEvent) { this.metricsEvent = metricsEvent; }

    };



    private URL mUrl;

    private String mUserAgent;
@@ -77,6 +87,9 @@ public class CaptivePortalLoginActivity extends Activity { 
    @Override

    protected void onCreate(Bundle savedInstanceState) {

        super.onCreate(savedInstanceState);



        logMetricsEvent(MetricsEvent.ACTION_CAPTIVE_PORTAL_LOGIN_ACTIVITY);



        mCm = ConnectivityManager.from(this);

        mNetwork = getIntent().getParcelableExtra(ConnectivityManager.EXTRA_NETWORK);

        mCaptivePortal = getIntent().getParcelableExtra(ConnectivityManager.EXTRA_CAPTIVE_PORTAL);
@@ -173,6 +186,7 @@ public class CaptivePortalLoginActivity extends Activity { 
            mCm.unregisterNetworkCallback(mNetworkCallback);

            mNetworkCallback = null;

        }

        logMetricsEvent(result.metricsEvent);

        switch (result) {

            case DISMISSED:

                mCaptivePortal.reportCaptivePortalDismissed();
@@ -381,6 +395,7 @@ public class CaptivePortalLoginActivity extends Activity { 


        @Override

        public void onReceivedSslError(WebView view, SslErrorHandler handler, SslError error) {

            logMetricsEvent(MetricsEvent.CAPTIVE_PORTAL_LOGIN_ACTIVITY_SSL_ERROR);

            Log.w(TAG, "SSL error (error: " + error.getPrimaryError() + " host: " +

                    // Only show host to avoid leaking private info.

                    Uri.parse(error.getUrl()).getHost() + " certificate: " +
@@ -492,4 +507,8 @@ public class CaptivePortalLoginActivity extends Activity { 
        }

        return url.getHost();

    }



    private void logMetricsEvent(int event) {

        MetricsLogger.action(this, event, getPackageName());

    }

}

proto/src/metrics_constants.proto

+5 −0
Original line number Diff line number Diff line
@@ -4090,6 +4090,11 @@ message MetricsEvent { 
    // OS: O DR

    SETTINGS_ASSIST_GESTURE_FIRST_TIME = 1012;



    // CaptivePortalLoginActivity displays SSL error page

    // CATEGORY: GLOBAL_SYSTEM_UI

    // OS: O DR

    CAPTIVE_PORTAL_LOGIN_ACTIVITY_SSL_ERROR = 1013;



    // Add new aosp constants above this line.

    // END OF AOSP CONSTANTS

  }