Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c603ca2d authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Apply fixes for EfficientStrings. 

Refactoring to avoid StringBuffer synchronization overhead.

Bug: 170978902
Test: none
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: Ibf843ed780c1202d5d96a11eaca889e592f19263
parent f18719bb

core/java/android/app/NotificationChannel.java

+1 −1
Original line number Diff line number Diff line
@@ -1144,7 +1144,7 @@ public final class NotificationChannel implements Parcelable { 
    }



    private static String longArrayToString(long[] values) {

        StringBuffer sb = new StringBuffer();

        StringBuilder sb = new StringBuilder();

        if (values != null && values.length > 0) {

            for (int i = 0; i < values.length - 1; i++) {

                sb.append(values[i]).append(DELIMITER);

core/java/android/content/SyncResult.java

+1 −1
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ public final class SyncResult implements Parcelable { 
     * @return debugging string.

     */

    public String toDebugString() {

        StringBuffer sb = new StringBuffer();

        StringBuilder sb = new StringBuilder();



        if (fullSyncRequested) {

            sb.append("f1");

core/java/android/hardware/hdmi/HdmiDeviceInfo.java

+1 −1
Original line number Diff line number Diff line
@@ -463,7 +463,7 @@ public class HdmiDeviceInfo implements Parcelable { 
    @NonNull

    @Override

    public String toString() {

        StringBuffer s = new StringBuffer();

        StringBuilder s = new StringBuilder();

        switch (mHdmiDeviceType) {

            case HDMI_DEVICE_TYPE_CEC:

                s.append("CEC: ");

core/java/android/hardware/hdmi/HdmiPortInfo.java

+1 −1
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ public final class HdmiPortInfo implements Parcelable { 
    @NonNull

    @Override

    public String toString() {

        StringBuffer s = new StringBuffer();

        StringBuilder s = new StringBuilder();

        s.append("port_id: ").append(mId).append(", ");

        s.append("type: ").append((mType == PORT_INPUT) ? "HDMI_IN" : "HDMI_OUT").append(", ");

        s.append("address: ").append(String.format("0x%04x", mAddress)).append(", ");

core/java/android/os/Debug.java

+3 −3
Original line number Diff line number Diff line
@@ -2468,7 +2468,7 @@ public final class Debug 
    @UnsupportedAppUsage

    public static String getCallers(final int depth) {

        final StackTraceElement[] callStack = Thread.currentThread().getStackTrace();

        StringBuffer sb = new StringBuffer();

        StringBuilder sb = new StringBuilder();

        for (int i = 0; i < depth; i++) {

            sb.append(getCaller(callStack, i)).append(" ");

        }
@@ -2483,7 +2483,7 @@ public final class Debug 
     */

    public static String getCallers(final int start, int depth) {

        final StackTraceElement[] callStack = Thread.currentThread().getStackTrace();

        StringBuffer sb = new StringBuffer();

        StringBuilder sb = new StringBuilder();

        depth += start;

        for (int i = start; i < depth; i++) {

            sb.append(getCaller(callStack, i)).append(" ");
@@ -2501,7 +2501,7 @@ public final class Debug 
     */

    public static String getCallers(final int depth, String linePrefix) {

        final StackTraceElement[] callStack = Thread.currentThread().getStackTrace();

        StringBuffer sb = new StringBuffer();

        StringBuilder sb = new StringBuilder();

        for (int i = 0; i < depth; i++) {

            sb.append(linePrefix).append(getCaller(callStack, i)).append("\n");

        }