Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5996b99 authored by Sang-Jun Park's avatar Sang-Jun Park Committed by Jean-Baptiste Queru
Browse files

Fix delivery report error with PENDING status in SMS 

1. According to TS 23.040, TP-Status values is changed properly.
2. When processing Status Report, it should be checked whether tpStatus is PENDING or FAILED.

Change-Id: I91c315cfb363f3e4b936c6b6b1a01083687a580f
parent 65aef151

core/java/android/provider/Telephony.java

100644 → 100755
+2 −2
Original line number Diff line number Diff line
@@ -114,8 +114,8 @@ public final class Telephony { 


        public static final int STATUS_NONE = -1;

        public static final int STATUS_COMPLETE = 0;

        public static final int STATUS_PENDING = 64;

        public static final int STATUS_FAILED = 128;

        public static final int STATUS_PENDING = 32;

        public static final int STATUS_FAILED = 64;



        /**

         * The subject of the message, if present

telephony/java/com/android/internal/telephony/gsm/GsmSMSDispatcher.java

100644 → 100755
+6 −1
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ import android.app.PendingIntent.CanceledException; 
import android.content.Intent;

import android.os.AsyncResult;

import android.os.Message;

import android.provider.Telephony.Sms;

import android.provider.Telephony.Sms.Intents;

import android.telephony.ServiceState;

import android.util.Config;
@@ -60,13 +61,17 @@ final class GsmSMSDispatcher extends SMSDispatcher { 
        String pduString = (String) ar.result;

        SmsMessage sms = SmsMessage.newFromCDS(pduString);



        int tpStatus = sms.getStatus();



        if (sms != null) {

            int messageRef = sms.messageRef;

            for (int i = 0, count = deliveryPendingList.size(); i < count; i++) {

                SmsTracker tracker = deliveryPendingList.get(i);

                if (tracker.mMessageRef == messageRef) {

                    // Found it.  Remove from list and broadcast.

                    if(tpStatus >= Sms.STATUS_FAILED || tpStatus < Sms.STATUS_PENDING ) {

                       deliveryPendingList.remove(i);

                    }

                    PendingIntent intent = tracker.mDeliveryIntent;

                    Intent fillIn = new Intent();

                    fillIn.putExtra("pdu", IccUtils.hexStringToBytes(pduString));