Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c56191f8 authored by Satoshi Kataoka's avatar Satoshi Kataoka
Browse files

Resolve inconsistent conditions in InputMethodService 

This change is addressing this issue by
1. call doFinishInput in onDestroy
2. fix the inconsistent condition of "mInputStarted"

Bug: 9197136
Change-Id: Iefe6b284e148e31bd212b255c41cb2cf548723d7
parent 087d2b2d

core/java/android/inputmethodservice/InputMethodService.java

+1 −2
Original line number Diff line number Diff line
@@ -381,7 +381,6 @@ public class InputMethodService extends AbstractInputMethodService { 
            if (DEBUG) Log.v(TAG, "unbindInput(): binding=" + mInputBinding

                    + " ic=" + mInputConnection);

            onUnbindInput();

            mInputStarted = false;

            mInputBinding = null;

            mInputConnection = null;

        }
@@ -719,7 +718,7 @@ public class InputMethodService extends AbstractInputMethodService { 
        super.onDestroy();

        mRootView.getViewTreeObserver().removeOnComputeInternalInsetsListener(

                mInsetsComputer);

        finishViews();

        doFinishInput();

        if (mWindowAdded) {

            // Disable exit animation for the current IME window

            // to avoid the race condition between the exit and enter animations