Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4e1489b authored by Peter Kalauskas's avatar Peter Kalauskas
Browse files

Move call to hide IME until next frame 

When dismissing lockscreen after password input, delay call to
IInputMethodManager#hideSoftInput() until the next frame.

This avoids jank during J<LOCKSCREEN_PASSWORD_DISAPPEAR>

Test: atrace before/after
Bug: 230620476
Change-Id: I541eedcbe61350d04056086385f1cf96a1a28bfd
parent 5d4978d3

packages/SystemUI/src/com/android/keyguard/KeyguardPasswordView.java

+13 −3
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ import android.animation.ValueAnimator; 
import android.content.Context;

import android.graphics.Insets;

import android.graphics.Rect;

import android.os.Trace;

import android.util.AttributeSet;

import android.view.WindowInsetsAnimationControlListener;

import android.view.WindowInsetsAnimationController;
@@ -44,6 +45,7 @@ import androidx.annotation.Nullable; 


import com.android.internal.widget.LockscreenCredential;

import com.android.internal.widget.TextViewInputDisabler;

import com.android.systemui.DejankUtils;

import com.android.systemui.R;

import com.android.systemui.animation.Interpolators;

/**
@@ -194,9 +196,17 @@ public class KeyguardPasswordView extends KeyguardAbsKeyInputView { 


                            @Override

                            public void onAnimationEnd(Animator animation) {

                                // Run this in the next frame since it results in a slow binder call

                                // to InputMethodManager#hideSoftInput()

                                DejankUtils.postAfterTraversal(() -> {

                                    Trace.beginSection("KeyguardPasswordView#onAnimationEnd");

                                    // // TODO(b/230620476): Make hideSoftInput oneway

                                    // controller.finish() eventually calls hideSoftInput

                                    controller.finish(false);

                                    runOnFinishImeAnimationRunnable();

                                    finishRunnable.run();

                                    Trace.endSection();

                                });

                            }

                        });

                        anim.setInterpolator(Interpolators.FAST_OUT_LINEAR_IN);