Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c45cb706 authored by Rupesh Bansal's avatar Rupesh Bansal
Browse files

Moving autobrightness display configs to a different file 

Currently, all the display configs are controlled from
display_device_config.xsd file. This has led to a lot of configs being
controlled from this single source, making it error prone and less
readable. This is to decouple that, and move the autobrightness related
display configs to a separate file. We choose to move autobrightness
configs because we soon plan to add more configs to this.

Bug: 235345267
Test: atest DisplayDeviceConfigTest#testConfigValues
Change-Id: Ia3ba1065663f478ffcb6f4ea5951958352679f76
parent 5a54deb0

services/core/xsd/display-device-config/autobrightness.xsd

0 → 100644
+33 −0
Original line number Diff line number Diff line 
<!--

    Copyright (C) 2022 The Android Open Source Project



    Licensed under the Apache License, Version 2.0 (the "License");

    you may not use this file except in compliance with the License.

    You may obtain a copy of the License at



         http://www.apache.org/licenses/LICENSE-2.0



    Unless required by applicable law or agreed to in writing, software

    distributed under the License is distributed on an "AS IS" BASIS,

    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

    See the License for the specific language governing permissions and

    limitations under the License.

-->

<xs:schema version="2.0"

           elementFormDefault="qualified"

           xmlns:xs="http://www.w3.org/2001/XMLSchema">

    <xs:complexType name="autoBrightness">

        <xs:sequence>

            <!-- Sets the debounce for autoBrightness brightening in millis-->

            <xs:element name="brighteningLightDebounceMillis" type="xs:nonNegativeInteger"

                        minOccurs="0" maxOccurs="1">

                <xs:annotation name="final"/>

            </xs:element>

            <!-- Sets the debounce for autoBrightness darkening in millis-->

            <xs:element name="darkeningLightDebounceMillis" type="xs:nonNegativeInteger"

                        minOccurs="0" maxOccurs="1">

                <xs:annotation name="final"/>

            </xs:element>

        </xs:sequence>

    </xs:complexType>

</xs:schema>
 
 No newline at end of file

services/core/xsd/display-device-config/display-device-config.xsd

+1 −16
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
<xs:schema version="2.0"

           elementFormDefault="qualified"

           xmlns:xs="http://www.w3.org/2001/XMLSchema">

    <xs:include schemaLocation="autobrightness.xsd" />

    <xs:element name="displayConfiguration">

        <xs:complexType>

            <xs:sequence>
@@ -102,22 +103,6 @@ 
    </xs:element>



    <!-- Type definitions -->



    <xs:complexType name="autoBrightness">

        <xs:sequence>

            <!-- Sets the debounce for autoBrightness brightening in millis-->

            <xs:element name="brighteningLightDebounceMillis" type="xs:nonNegativeInteger"

                        minOccurs="0" maxOccurs="1">

                <xs:annotation name="final"/>

            </xs:element>

            <!-- Sets the debounce for autoBrightness darkening in millis-->

            <xs:element name="darkeningLightDebounceMillis" type="xs:nonNegativeInteger"

                        minOccurs="0" maxOccurs="1">

                <xs:annotation name="final"/>

            </xs:element>

        </xs:sequence>

    </xs:complexType>



    <xs:complexType name="displayQuirks">

        <xs:sequence>

            <xs:element name="quirk" type="xs:string" minOccurs="0" maxOccurs="unbounded" />