Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3510453 authored by Andrew Rossignol's avatar Andrew Rossignol Committed by Brian Duddie
Browse files

ContextHub: Avoid reference leaks 

The ContextHub HAL was leaking references in passOnOsResponse. An
example of this is when a sensor hub reset occurs. If many of these
resets happen, the local reference pool is exhausted and a crash
in the HAL occurs.

Bug: 30706325
Change-Id: Ica5328137a7033f512d7fb1ccf6fa138eab55091
(cherry picked from commit 52dda598)
parent d90b69ff

core/jni/android_hardware_location_ContextHubService.cpp

+2 −0
Original line number Diff line number Diff line
@@ -603,6 +603,8 @@ static void passOnOsResponse(uint32_t hubHandle, uint32_t msgType, 
    env->CallIntMethod(db.jniInfo.jContextHubService,

                       db.jniInfo.contextHubServiceMsgReceiptCallback,

                       jheader, jmsg);

    env->DeleteLocalRef(jmsg);

    env->DeleteLocalRef(jheader);



    delete[] msg;

}