Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c34b5738 authored by Mohammad Samiul Islam's avatar Mohammad Samiul Islam
Browse files

Remove duplicate logic from ModuleTestUtils 

Bug: 160296318
Test: atest StagedInstallInternalTest
Change-Id: Ia31fc9d5246203da1869cc6d0e6ffcfc8d794080
parent 22e36b1a

tests/StagedInstallTest/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ java_test_host { 
        "compatibility-tradefed",

        "frameworks-base-hostutils",

        "module_test_util",

        "cts-install-lib-host",

    ],

    data: [

        ":com.android.apex.cts.shim.v2_prebuilt",

tests/StagedInstallTest/src/com/android/tests/stagedinstallinternal/host/StagedInstallInternalTest.java

+5 −3
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ import static org.junit.Assert.assertTrue; 
import static org.junit.Assert.fail;

import static org.junit.Assume.assumeTrue;



import com.android.cts.install.lib.host.InstallUtilsHost;

import com.android.ddmlib.Log;

import com.android.tests.rollback.host.AbandonSessionsRule;

import com.android.tests.util.ModuleTestUtils;
@@ -49,6 +50,7 @@ public class StagedInstallInternalTest extends BaseHostJUnit4Test { 
    private static final String APK_A = "TestAppAv1.apk";



    private final ModuleTestUtils mTestUtils = new ModuleTestUtils(this);

    private final InstallUtilsHost mHostUtils = new InstallUtilsHost(this);



    /**

     * Runs the given phase of a test by calling into the device.
@@ -93,7 +95,7 @@ public class StagedInstallInternalTest extends BaseHostJUnit4Test { 
    @Test

    public void testAdbStagedInstallWaitForReadyFlagWorks() throws Exception {

        assumeTrue("Device does not support updating APEX",

                mTestUtils.isApexUpdateSupported());

                mHostUtils.isApexUpdateSupported());



        File apexFile = mTestUtils.getTestFile(SHIM_V2);

        String output = getDevice().executeAdbCommand("install", "--staged",
@@ -107,7 +109,7 @@ public class StagedInstallInternalTest extends BaseHostJUnit4Test { 
    @Test

    public void testAdbStagedInstallNoWaitFlagWorks() throws Exception {

        assumeTrue("Device does not support updating APEX",

                mTestUtils.isApexUpdateSupported());

                mHostUtils.isApexUpdateSupported());



        File apexFile = mTestUtils.getTestFile(SHIM_V2);

        String output = getDevice().executeAdbCommand("install", "--staged",
@@ -122,7 +124,7 @@ public class StagedInstallInternalTest extends BaseHostJUnit4Test { 
    @Test

    public void testAdbInstallMultiPackageCommandWorks() throws Exception {

        assumeTrue("Device does not support updating APEX",

                mTestUtils.isApexUpdateSupported());

                mHostUtils.isApexUpdateSupported());



        File apexFile = mTestUtils.getTestFile(SHIM_V2);

        File apkFile = mTestUtils.getTestFile(APK_A);