Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c334ea0e authored by Fabian Kozynski's avatar Fabian Kozynski
Browse files

Reduce log importance and improve logging 

The first time after QS is created, there are no tiles to animate, so we
should skip logging that we cannot find each tile. This is ok.
Otherwise, warn when we cannot find a tile that should be there.

Bug: 181269159
Test: build and check log
Change-Id: I7e60ba9ce5fd8ca9dc0b1e0b5a6180249c741db4
parent ec012bc4

packages/SystemUI/src/com/android/systemui/qs/QSAnimator.java

+100 −96
Original line number Diff line number Diff line
@@ -233,6 +233,7 @@ public class QSAnimator implements Callback, PageListener, Listener, OnLayoutCha 
        boolean qsSideLabelsEnabled = mFeatureFlags.isQSLabelsEnabled();

        int qqsTileHeight = 0;



        if (mQsPanelController.areThereTiles()) {

            for (QSTile tile : tiles) {

                QSTileView tileView = mQsPanelController.getTileView(tile);

                if (tileView == null) {
@@ -296,8 +297,10 @@ public class QSAnimator implements Callback, PageListener, Listener, OnLayoutCha 
                            getRelativePosition(loc2, qsLabelContainer, view);

                            yDiff = loc2[1] - loc1[1] - yOffset;



                        translationYBuilder.addFloat(qqsLabelContainer, "translationY", 0, yDiff);

                        translationYBuilder.addFloat(qsLabelContainer, "translationY", -yDiff, 0);

                            translationYBuilder.addFloat(qqsLabelContainer, "translationY", 0,

                                    yDiff);

                            translationYBuilder.addFloat(qsLabelContainer, "translationY", -yDiff,

                                    0);

                            mAllViews.add(qqsLabelContainer);

                            mAllViews.add(qsLabelContainer);

                        }
@@ -352,6 +355,7 @@ public class QSAnimator implements Callback, PageListener, Listener, OnLayoutCha 
                mAllViews.add(tileView);

                count++;

            }

        }



        if (mAllowFancy) {

            // Make brightness appear static position and alpha in through second half.

packages/SystemUI/src/com/android/systemui/qs/QSPanelControllerBase.java

+3 −0
Original line number Diff line number Diff line
@@ -228,6 +228,9 @@ public abstract class QSPanelControllerBase<T extends QSPanel> extends ViewContr 
        return mHost.createTile(subPanel);

    }



    boolean areThereTiles() {

        return !mRecords.isEmpty();

    }



    QSTileView getTileView(QSTile tile) {

        for (QSPanelControllerBase.TileRecord r : mRecords) {