Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c24469af authored by Charles Munger's avatar Charles Munger
Browse files

Deprecate LoginFilter 

This class hardcodes incorrect assumptions about Google services into an
open source project.

Bug: 144042891
Test: No behavior changes
Change-Id: Ibf811f6390599633056bf1bfe042cb70b2f0f881
parent 49af39e7

api/current.txt

+18 −18
Original line number Diff line number Diff line
@@ -46112,30 +46112,30 @@ package android.text { 
  public static class Layout.Directions {

  }













  public abstract class LoginFilter implements android.text.InputFilter {













    method public CharSequence filter(CharSequence, int, int, android.text.Spanned, int, int);













    method public abstract boolean isAllowed(char);













    method public void onInvalidCharacter(char);













    method public void onStart();













    method public void onStop();













  @Deprecated public abstract class LoginFilter implements android.text.InputFilter {













    method @Deprecated public CharSequence filter(CharSequence, int, int, android.text.Spanned, int, int);













    method @Deprecated public abstract boolean isAllowed(char);













    method @Deprecated public void onInvalidCharacter(char);













    method @Deprecated public void onStart();













    method @Deprecated public void onStop();















  }



























  public static class LoginFilter.PasswordFilterGMail extends android.text.LoginFilter {













    ctor public LoginFilter.PasswordFilterGMail();













    ctor public LoginFilter.PasswordFilterGMail(boolean);













    method public boolean isAllowed(char);













  @Deprecated public static class LoginFilter.PasswordFilterGMail extends android.text.LoginFilter {













    ctor @Deprecated public LoginFilter.PasswordFilterGMail();













    ctor @Deprecated public LoginFilter.PasswordFilterGMail(boolean);













    method @Deprecated public boolean isAllowed(char);















  }



























  public static class LoginFilter.UsernameFilterGMail extends android.text.LoginFilter {













    ctor public LoginFilter.UsernameFilterGMail();













    ctor public LoginFilter.UsernameFilterGMail(boolean);













    method public boolean isAllowed(char);













  @Deprecated public static class LoginFilter.UsernameFilterGMail extends android.text.LoginFilter {













    ctor @Deprecated public LoginFilter.UsernameFilterGMail();













    ctor @Deprecated public LoginFilter.UsernameFilterGMail(boolean);













    method @Deprecated public boolean isAllowed(char);















  }



























  public static class LoginFilter.UsernameFilterGeneric extends android.text.LoginFilter {













    ctor public LoginFilter.UsernameFilterGeneric();













    ctor public LoginFilter.UsernameFilterGeneric(boolean);













    method public boolean isAllowed(char);













  @Deprecated public static class LoginFilter.UsernameFilterGeneric extends android.text.LoginFilter {













    ctor @Deprecated public LoginFilter.UsernameFilterGeneric();













    ctor @Deprecated public LoginFilter.UsernameFilterGeneric(boolean);













    method @Deprecated public boolean isAllowed(char);















  }





























  public interface NoCopySpan {

























core/java/android/text/LoginFilter.java



+10
−1




























Original line number
Diff line number
Diff line








@@ -19,7 +19,10 @@ package android.text;













/**















 * Abstract class for filtering login-related text (user names and passwords)















 * 













 * @deprecated Password requirements should not be hardcoded in clients. This class also does not













 * handle non-BMP characters.















 */













@Deprecated















public abstract class LoginFilter implements InputFilter {















    private boolean mAppendInvalid;  // whether to append or ignore invalid characters















    /**










@@ -130,7 +133,9 @@ public abstract class LoginFilter implements InputFilter {













     * account creation. It prevents the user from entering user names with characters other than 















     * [a-zA-Z0-9.]. 















     * 













     * @deprecated Do not encode assumptions about Google account names into client applications.















     */













    @Deprecated















    public static class UsernameFilterGMail extends LoginFilter {















        















        public UsernameFilterGMail() {










@@ -191,7 +196,11 @@ public abstract class LoginFilter implements InputFilter {













     * This filter is compatible with GMail passwords which restricts characters to 















     * the Latin-1 (ISO8859-1) char set.















     *













     * @deprecated Do not handle a user's Google password. Refer to













     *   <a href="https://support.google.com/accounts/answer/32040">Google Help</a> for













     *   password restriction information.















     */













    @Deprecated















    public static class PasswordFilterGMail extends LoginFilter {















        















        public PasswordFilterGMail() {