Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c11f77fb authored by Fabrice Di Meglio's avatar Fabrice Di Meglio
Browse files

Fix bug #7173155 API REVIEW: android.view.View 

- remove getFocusRect(Rect) as it was redundant
- fix Javadoc

Change-Id: I3784c4b0a38770cba5d3ba09196f9271050a3c20
parent 5e900e3a

api/current.txt

+0 −1
Original line number Diff line number Diff line
@@ -24771,7 +24771,6 @@ package android.view { 
    method public long getDrawingTime();

    method public boolean getFilterTouchesWhenObscured();

    method public boolean getFitsSystemWindows();

    method public void getFocusRect(android.graphics.Rect);

    method public java.util.ArrayList<android.view.View> getFocusables(int);

    method public void getFocusedRect(android.graphics.Rect);

    method public boolean getGlobalVisibleRect(android.graphics.Rect, android.graphics.Point);

core/java/android/view/FocusFinder.java

+1 −1
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ public class FocusFinder { 
            if (focusable == focused || focusable == root) continue;



            // get focus bounds of other view in same coordinate system

            focusable.getFocusRect(mOtherRect);

            focusable.getFocusedRect(mOtherRect);

            root.offsetDescendantRectToMyCoords(focusable, mOtherRect);



            if (isBetterCandidate(direction, focusedRect, mOtherRect, mBestCandidateRect)) {

core/java/android/view/View.java

+1 −13
Original line number Diff line number Diff line
@@ -8635,18 +8635,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
        }

    }













    /**













     * When searching for a view to focus this rectangle is used when considering if this view is













     * a good candidate for receiving focus.













     *













     * By default, the rectangle is the {@link #getDrawingRect}) of the view.













     *













     * @param r The rectangle to fill in, in this view's coordinates.













     */













    public void getFocusRect(Rect r) {













        getDrawingRect(r);













    }



























   /**















     * Utility method to retrieve the inverse of the current mMatrix property.















     * We cache the matrix to avoid recalculating it when transform properties










@@ -9625,7 +9613,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













     * When a view has focus and the user navigates away from it, the next view is searched for















     * starting from the rectangle filled in by this method.















     *













     * By default, the rectange is the {@link #getDrawingRect(android.graphics.Rect)})













     * By default, the rectangle is the {@link #getDrawingRect(android.graphics.Rect)})















     * of the view.  However, if your view maintains some idea of internal selection,















     * such as a cursor, or a selected row or column, you should override this method and















     * fill in a more specific rectangle.