Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0f627d7 authored by Beverly's avatar Beverly Committed by Beverly Tai
Browse files

Don't use dp for lock icon padding 

We don't want it to scale with density
changes. It scales in the wrong direction.

This was also causing a difference in lock icon size for foldable
devices where the inner display is using a different lock icon padding
than the outer display.

Test: visual manual inspection
Fixes: 259677170
Fixes: 264738021
Change-Id: I4075fd5e3f0aec7472edc56a0f8c95be5e68d65a
parent 633bd1e8

packages/SystemUI/res-keyguard/values-sw600dp/dimens.xml

+0 −3
Original line number Diff line number Diff line
@@ -25,9 +25,6 @@ 
    <!-- Margin around the various security views -->

    <dimen name="keyguard_security_view_top_margin">12dp</dimen>



    <!-- Padding for the lock icon on the keyguard -->

    <dimen name="lock_icon_padding">16dp</dimen>



    <!-- Overload default clock widget parameters -->

    <dimen name="widget_big_font_size">100dp</dimen>

    <dimen name="widget_label_font_size">18sp</dimen>

packages/SystemUI/src/com/android/keyguard/LockIconViewController.java

+1 −0
Original line number Diff line number Diff line
@@ -429,6 +429,7 @@ public class LockIconViewController extends ViewController<LockIconView> impleme 
        pw.println(" mStatusBarState: " + StatusBarState.toString(mStatusBarState));

        pw.println(" mInterpolatedDarkAmount: " + mInterpolatedDarkAmount);

        pw.println(" mSensorTouchLocation: " + mSensorTouchLocation);

        pw.println(" mDefaultPaddingPx: " + mDefaultPaddingPx);



        if (mView != null) {

            mView.dump(pw, args);