Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0bcc1b4 authored by Pablo Gamito's avatar Pablo Gamito
Browse files

Fix ProtoLogViewerConfigReader bug 

If we unloaded a viewer config group we would never be able to re-loaded it because we were not clearing the groups from mGroupHashes which we used to check if the group was loaded.

Flag: EXEMPT minor bug fix
Test: atest com.android.internal.protolog.ProtoLogViewerConfigReaderTest
Change-Id: I8e8d1d064212e905c6a0179b4e4cd609a3985945
parent 691e8f28

core/java/com/android/internal/protolog/ProtoLogViewerConfigReader.java

+1 −0
Original line number Diff line number Diff line
@@ -96,6 +96,7 @@ public class ProtoLogViewerConfigReader { 
                logger.log("Unloading viewer config hash " + hash);

                mLogMessageMap.remove(hash);

            }

            mGroupHashes.remove(group);

        }

    }

tests/Tracing/src/com/android/internal/protolog/ProtoLogViewerConfigReaderTest.java

+8 −0
Original line number Diff line number Diff line
@@ -121,4 +121,12 @@ public class ProtoLogViewerConfigReaderTest { 
        assertNull(mConfig.getViewerString(4));

        assertNull(mConfig.getViewerString(5));

    }



    @Test

    public void loadUnloadAndReloadViewerConfig() {

        loadViewerConfig();

        unloadViewerConfig();

        loadViewerConfig();

        unloadViewerConfig();

    }

}