Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bff5c972 authored by Nergi Rahardi's avatar Nergi Rahardi
Browse files

Replace region intersection change from quickReject to use Region#op 

quickReject only checks outer bounds and not the invididual region
boundaries, this might give false negative (as the method doc suggests).

This caused a bug where window is still added to a11y window list
although it has been fully covered by a dialog (still intersects with
unaccountedSpace).

Bug: 240885392
Test: atest android.autofillservice.cts.servicebehavior.SettingsIntentTest
Change-Id: I7fc226e2288c2433e427d1e8ef173a3a21a20edc
parent ff0cd826

services/core/java/com/android/server/wm/AccessibilityController.java

+2 −1
Original line number Diff line number Diff line
@@ -1655,7 +1655,8 @@ final class AccessibilityController { 
            }



            // If the window is completely covered by other windows - ignore.

            if (unaccountedSpace.quickReject(regionInScreen)) {

            Region intersectionWindow = mTempRegion1;

            if (!intersectionWindow.op(unaccountedSpace, regionInScreen, Region.Op.INTERSECT)) {

                return false;

            }