Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf3a3353 authored by Philip Quinn's avatar Philip Quinn Committed by Automerger Merge Worker
Browse files

Merge "Revert "Un-obscure the Telephony phone account ID."" into tm-dev am: ec77a90a 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18130643



Change-Id: Ib337d6a43e9ef34800d5bbb7706c73eb022fb7c0
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 1ec9e808 ec77a90a

telecomm/java/android/telecom/PhoneAccountHandle.java

+8 −25
Original line number Diff line number Diff line
@@ -46,14 +46,6 @@ import java.util.Objects; 
 * See {@link PhoneAccount}, {@link TelecomManager}.

 */

public final class PhoneAccountHandle implements Parcelable {

    /**

     * Expected component name of Telephony phone accounts; ONLY used to determine if we should log

     * the phone account handle ID.

     */

    private static final ComponentName TELEPHONY_COMPONENT_NAME =

            new ComponentName("com.android.phone",

                    "com.android.services.telephony.TelephonyConnectionService");



    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 127403196)

    private final ComponentName mComponentName;

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 115609023)
@@ -144,23 +136,14 @@ public final class PhoneAccountHandle implements Parcelable { 


    @Override

    public String toString() {

        StringBuilder sb = new StringBuilder()

                .append(mComponentName)

                .append(", ");



        if (mComponentName.equals(TELEPHONY_COMPONENT_NAME)) {

            // Telephony phone account handles are now keyed by subscription id which is not

            // sensitive.

            sb.append(mId);

        } else {

        // Note: Log.pii called for mId as it can contain personally identifying phone account

        // information such as SIP account IDs.

            sb.append(Log.pii(mId));

        }

        sb.append(", ");

        sb.append(mUserHandle);



        return sb.toString();

        return new StringBuilder().append(mComponentName)

                    .append(", ")

                    .append(Log.pii(mId))

                    .append(", ")

                    .append(mUserHandle)

                    .toString();

    }



    @Override