Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bedc2b87 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Improve multi-user consistency in onFinishPackageChangesInternal() 

With this CL we start applying the same logic among users when an APK
that provides the currently selected IME.

Previously we only updated the secure settings when called for
background users.

No abrupt observable behavior change is expected/intended.

Bug: 350386877
Flag: EXEMPT refactor
Test: manually verified
Change-Id: Ia03a9247e1ca9861e0921aac57dbeefbd0e56e57
parent 1054f4ec

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −8
Original line number Diff line number Diff line
@@ -785,14 +785,7 @@ public final class InputMethodManagerService implements IInputMethodManagerImpl. 
                    int change = isPackageDisappearing(imi.getPackageName());

                    if (change == PACKAGE_PERMANENT_CHANGE) {

                        Slog.i(TAG, "Input method uninstalled, disabling: " + imi.getComponent());

                        if (isCurrentUser) {

                        setInputMethodEnabledLocked(imi.getId(), false, userId);

                        } else {

                            settings.buildAndPutEnabledInputMethodsStrRemovingId(

                                    new StringBuilder(),

                                    settings.getEnabledInputMethodsAndSubtypeList(),

                                    imi.getId());

                        }

                    } else if (change == PACKAGE_UPDATING) {

                        Slog.i(TAG, "Input method reinstalling, clearing additional subtypes: "

                                + imi.getComponent());