Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd89c480 authored by Eric Lin's avatar Eric Lin
Browse files

Refactor to inline the isNewInTaskView argument. 

The local boolean variable isNewInTaskView was only used to pass a value
to the prepareOpenAnimation method. Depending on the conditional branch,
this value was always either true or false.

This change removes the temporary variable and inlines the boolean
literal directly into the method call. This is a pure refactoring that
simplifies the code and improves readability without altering behavior.

Bug: 387193964
Flag: EXEMPT PURE_REFACTOR
Test: atest WMShellUnitTests:TaskViewTransitionsTest
Test: atest WMShellUnitTests:TaskViewTransitionStartAnimationTest
Change-Id: Ic67a25d12d4288ef2d1aa9abf07bea1e3d052dab
parent 597d8b1a

libs/WindowManager/Shell/src/com/android/wm/shell/taskview/TaskViewTransitions.java

+4 −6
Original line number Original line Diff line number Diff line
@@ -835,18 +835,16 @@ public class TaskViewTransitions implements Transitions.TransitionHandler, TaskV 
                            startTransaction, finishTransaction, taskInfo, leash, wct);

                            startTransaction, finishTransaction, taskInfo, leash, wct);

                    break;

                    break;

                case TRANSIT_TO_FRONT:

                case TRANSIT_TO_FRONT:

                    boolean isNewInTaskView = false;

                    if (wct == null) wct = new WindowContainerTransaction();

                    if (wct == null) wct = new WindowContainerTransaction();

                    if (infoTv == null && pending != null && isTaskToTaskView(task, pending)) {

                    if (infoTv == null && pending != null && isTaskToTaskView(task, pending)) {

                        // The task is being moved into taskView, so it is still "new" from

                        // The task is being moved into taskView, so it is still "new" from

                        // TaskView's perspective (e.g. task being moved into a bubble)

                        // TaskView's perspective (e.g. task being moved into a bubble)

                        stillNeedsMatchingLaunch = false;

                        stillNeedsMatchingLaunch = false;

                        isNewInTaskView = true;

                        prepareOpenAnimation(pending.mTaskView, true /* isNewInTaskView */,

                        prepareOpenAnimation(pending.mTaskView, isNewInTaskView, startTransaction,

                                startTransaction, finishTransaction, taskInfo, leash, wct);

                                finishTransaction, taskInfo, leash, wct);

                    } else {

                    } else {

                        prepareOpenAnimation(infoTv, isNewInTaskView, startTransaction,

                        prepareOpenAnimation(infoTv, false /* isNewInTaskView */,

                                finishTransaction, taskInfo, leash, wct);

                                startTransaction, finishTransaction, taskInfo, leash, wct);

                    }

                    }

                    break;

                    break;

                case TRANSIT_CHANGE:

                case TRANSIT_CHANGE: