Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd88529d authored by Jonathan Dixon's avatar Jonathan Dixon Committed by Android Git Automerger
Browse files

am 1bb6a7dc: am a8137c0c: am b1b2789d: Merge "Do not require WebView usage to...

am 1bb6a7dc: am a8137c0c: am b1b2789d: Merge "Do not require WebView usage to come from main thread" into klp-dev

* commit '1bb6a7dc':
  Do not require WebView usage to come from main thread
parents 8cca8b05 1bb6a7dc
Loading
Loading
Loading
Loading
+10 −9
Original line number Diff line number Diff line
@@ -701,7 +701,6 @@ public class WebView extends AbsoluteLayout
     */
    @Deprecated
    public static void enablePlatformNotifications() {
        checkThread();
        getFactory().getStatics().setPlatformNotificationsEnabled(true);
    }

@@ -714,7 +713,6 @@ public class WebView extends AbsoluteLayout
     */
    @Deprecated
    public static void disablePlatformNotifications() {
        checkThread();
        getFactory().getStatics().setPlatformNotificationsEnabled(false);
    }

@@ -1740,7 +1738,6 @@ public class WebView extends AbsoluteLayout
     * @param enabled whether to enable web contents debugging
     */
    public static void setWebContentsDebuggingEnabled(boolean enabled) {
        checkThread();
        getFactory().getStatics().setWebContentsDebuggingEnabled(enabled);
    }

@@ -1753,7 +1750,6 @@ public class WebView extends AbsoluteLayout
     */
    @Deprecated
    public static synchronized PluginList getPluginList() {
        checkThread();
        return new PluginList();
    }

@@ -2107,13 +2103,18 @@ public class WebView extends AbsoluteLayout
        return WebViewFactory.getProvider();
    }

    private static void checkThread() {
        if (Looper.myLooper() != Looper.getMainLooper()) {
    private final Looper mWebViewThread = Looper.myLooper();

    private void checkThread() {
        // Ignore mWebViewThread == null because this can be called during in the super class
        // constructor, before this class's own constructor has even started.
        if (mWebViewThread != null && Looper.myLooper() != mWebViewThread) {
            Throwable throwable = new Throwable(
                    "Warning: A WebView method was called on thread '" +
                    "A WebView method was called on thread '" +
                    Thread.currentThread().getName() + "'. " +
                    "All WebView methods must be called on the UI thread. " +
                    "Future versions of WebView may not support use on other threads.");
                    "All WebView methods must be called on the same thread. " +
                    "(Expected Looper " + mWebViewThread + " called on " + Looper.myLooper() +
                    ", FYI main Looper is " + Looper.getMainLooper() + ")");
            Log.w(LOGTAG, Log.getStackTraceString(throwable));
            StrictMode.onWebViewMethodCalledOnWrongThread(throwable);