Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcc73036 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Disable IO on IMMS#mHandler 

Now we are ready to lock down IMMS#mHandler to disallow any IO
operation there. At least the original reason why we had to allow IO
on the handler was already addressed [1].

There must be no observable behavior change as long as there is no
assertion failure.

 [1]: I4400519f133638c03205f7a8902f7e00c291eda8
      f4887903

Bug: 343601565
Fix: 196206770
Test: presubmit
Flag: EXEMPT refactor
Change-Id: Iba30c7706a991ec5a0a8b94bb62e47a25e6cb4e0
parent fca524fb

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -944,7 +944,7 @@ public final class InputMethodManagerService implements IInputMethodManagerImpl. 
            // TODO(b/196206770): Disallow I/O on this thread. Currently it's needed for loading

            // additional subtypes in switchUserOnHandlerLocked().

            final ServiceThread thread = new ServiceThread(HANDLER_THREAD_NAME,

                    Process.THREAD_PRIORITY_FOREGROUND, true /* allowIo */);

                    Process.THREAD_PRIORITY_FOREGROUND, false /* allowIo */);

            thread.start();



            final ServiceThread ioThread = new ServiceThread(PACKAGE_MONITOR_THREAD_NAME,