Commit bc68fd68 authored Dec 26, 2014 by Dohyun Lee Committed by Steve Kondik Mar 21, 2015

Avert duplicating translation in drawing a background drawable



When bounds of a background drawable of a view is set then
the drawable is translated into its left and top position
twice by:

 1. mBackgroundRenderNode.setLeftTopRightBottom() when
    creating or updaing the display list for the drawable.

 2. OpenGLRenderer during actual rendering. For example,
    the translation is done by loadTranslate() call to a
    model view matrix in setupDrawModelView() for drawing
    a simple colored rectangle.

This patch removes the translation described in step 1
above since all works for the translation of a background
drawable is done by OpenGLRenderer appropriately.

Change-Id: I9b8549b36215d567a5f43e1bb7bd02243a2377d1
Signed-off-by: Dohyun Lee <dohyun.lee@lge.com>

parent 48aa73da

core/java/android/view/View.java

+0 −1

Original line number	Diff line number	Diff line
		@@ -15474,7 +15474,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
		}

		// Set up drawable properties that are view-independent.
		renderNode.setLeftTopRightBottom(bounds.left, bounds.top, bounds.right, bounds.bottom);
		renderNode.setProjectBackwards(drawable.isProjected());
		renderNode.setProjectionReceiver(true);
		renderNode.setClipToBounds(false);