Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc34eb88 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Add comments to the arguments passed to FrameTracker"

parents bde347e0 7080b677

core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java

+2 −1
Original line number Diff line number Diff line
@@ -77,7 +77,8 @@ public class FrameTrackerTest { 


        Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);

        mTracker = Mockito.spy(

                new FrameTracker(session, handler, mRenderer, mWrapper, 1, -1));

                new FrameTracker(session, handler, mRenderer, mWrapper,

                        /*traceThresholdMissedFrames=*/ 1, /*traceThresholdFrameTimeMillis=*/ -1));

        doNothing().when(mTracker).triggerPerfetto();

    }

core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java

+4 −2
Original line number Diff line number Diff line
@@ -94,7 +94,8 @@ public class InteractionJankMonitorTest { 
        Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);

        FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(),

                new ThreadedRendererWrapper(mView.getThreadedRenderer()),

                new FrameMetricsWrapper(), 1, -1));

                new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1,

                /*traceThresholdFrameTimeMillis=*/ -1));

        doReturn(tracker).when(monitor).createFrameTracker(any());



        // Simulate a trace session and see if begin / end are invoked.
@@ -150,7 +151,8 @@ public class InteractionJankMonitorTest { 
        Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);

        FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(),

                new ThreadedRendererWrapper(mView.getThreadedRenderer()),

                new FrameMetricsWrapper(), 1, -1));

                new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1,

                /*traceThresholdFrameTimeMillis=*/ -1));

        doReturn(tracker).when(monitor).createFrameTracker(any());



        assertThat(monitor.begin(session.getCuj())).isTrue();