Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbdec456 authored by Ioana Stefan's avatar Ioana Stefan
Browse files

Add InputConnection app side tracing 

This change adds tracing for the methods exposed by the InputConnection
interface. The tracing is added to the wrapper class used to handle
InputConnection implementations created by different apps.

Bug: 154348613
Test: flash a device
      record a trace with Perfetto at https://ui.perfetto.dev/#!/record
      visualize traces and duration of tracing tags
Change-Id: I6718aa3183c95fc6802d93137e22d21b71869cfc
parent c47b324d

core/java/com/android/internal/view/IInputConnectionWrapper.java

+263 −148
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ import android.os.Handler; 
import android.os.Looper;

import android.os.Message;

import android.os.RemoteException;

import android.os.Trace;

import android.util.Log;

import android.view.KeyEvent;

import android.view.inputmethod.CompletionInfo;
@@ -265,7 +266,10 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
    void executeMessage(Message msg) {

        switch (msg.what) {

            case DO_GET_TEXT_AFTER_CURSOR: {

                final ICharSequenceResultCallback callback = (ICharSequenceResultCallback) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getTextAfterCursor");

                try {

                    final ICharSequenceResultCallback callback =

                            (ICharSequenceResultCallback) msg.obj;

                    final InputConnection ic = getInputConnection();

                    final CharSequence result;

                    if (ic == null || !isActive()) {
@@ -280,10 +284,16 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        Log.w(TAG, "Failed to return the result to getTextAfterCursor()."

                            + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_GET_TEXT_BEFORE_CURSOR: {

                final ICharSequenceResultCallback callback = (ICharSequenceResultCallback) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getTextBeforeCursor");

                try {

                    final ICharSequenceResultCallback callback =

                            (ICharSequenceResultCallback) msg.obj;

                    final InputConnection ic = getInputConnection();

                    final CharSequence result;

                    if (ic == null || !isActive()) {
@@ -298,10 +308,16 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        Log.w(TAG, "Failed to return the result to getTextBeforeCursor()."

                            + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_GET_SELECTED_TEXT: {

                final ICharSequenceResultCallback callback = (ICharSequenceResultCallback) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getSelectedText");

                try {

                    final ICharSequenceResultCallback callback =

                            (ICharSequenceResultCallback) msg.obj;

                    final InputConnection ic = getInputConnection();

                    final CharSequence result;

                    if (ic == null || !isActive()) {
@@ -316,10 +332,14 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        Log.w(TAG, "Failed to return the result to getSelectedText()."

                                + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_GET_SURROUNDING_TEXT: {

                final SomeArgs args = (SomeArgs) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getSurroundingText");

                try {

                    int beforeLength = (int) args.arg1;

                    int afterLength  = (int) args.arg2;
@@ -341,11 +361,14 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                                + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                    args.recycle();

                }

                return;

            }

            case DO_GET_CURSOR_CAPS_MODE: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getCursorCapsMode");

                try {

                    final IIntResultCallback callback = (IIntResultCallback) msg.obj;

                    final InputConnection ic = getInputConnection();

                    final int result;
@@ -361,10 +384,14 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        Log.w(TAG, "Failed to return the result to getCursorCapsMode()."

                            + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_GET_EXTRACTED_TEXT: {

                final SomeArgs args = (SomeArgs) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#getExtractedText");

                try {

                    final ExtractedTextRequest request = (ExtractedTextRequest) args.arg1;

                    final IExtractedTextResultCallback callback =
@@ -384,83 +411,126 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                                + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                    args.recycle();

                }

                return;

            }

            case DO_COMMIT_TEXT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#commitText");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "commitText on inactive InputConnection");

                        return;

                    }

                    ic.commitText((CharSequence) msg.obj, msg.arg1);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_SET_SELECTION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#setSelection");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "setSelection on inactive InputConnection");

                        return;

                    }

                    ic.setSelection(msg.arg1, msg.arg2);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_PERFORM_EDITOR_ACTION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#performEditorAction");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "performEditorAction on inactive InputConnection");

                        return;

                    }

                    ic.performEditorAction(msg.arg1);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_PERFORM_CONTEXT_MENU_ACTION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#performContextMenuAction");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "performContextMenuAction on inactive InputConnection");

                        return;

                    }

                    ic.performContextMenuAction(msg.arg1);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_COMMIT_COMPLETION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#commitCompletion");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "commitCompletion on inactive InputConnection");

                        return;

                    }

                    ic.commitCompletion((CompletionInfo) msg.obj);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_COMMIT_CORRECTION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#commitCorrection");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "commitCorrection on inactive InputConnection");

                        return;

                    }

                    ic.commitCorrection((CorrectionInfo) msg.obj);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_SET_COMPOSING_TEXT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#setComposingText");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "setComposingText on inactive InputConnection");

                        return;

                    }

                    ic.setComposingText((CharSequence) msg.obj, msg.arg1);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_SET_COMPOSING_REGION: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#setComposingRegion");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "setComposingRegion on inactive InputConnection");

                        return;

                    }

                    ic.setComposingRegion(msg.arg1, msg.arg2);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_FINISH_COMPOSING_TEXT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#finishComposingText");

                try {

                    if (isFinished()) {

                        // In this case, #finishComposingText() is guaranteed to be called already.

                        // There should be no negative impact if we ignore this call silently.
@@ -479,64 +549,99 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        return;

                    }

                    ic.finishComposingText();

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_SEND_KEY_EVENT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#sendKeyEvent");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "sendKeyEvent on inactive InputConnection");

                        return;

                    }

                    ic.sendKeyEvent((KeyEvent) msg.obj);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_CLEAR_META_KEY_STATES: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#clearMetaKeyStates");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "clearMetaKeyStates on inactive InputConnection");

                        return;

                    }

                    ic.clearMetaKeyStates(msg.arg1);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_DELETE_SURROUNDING_TEXT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#deleteSurroundingText");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "deleteSurroundingText on inactive InputConnection");

                        return;

                    }

                    ic.deleteSurroundingText(msg.arg1, msg.arg2);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_DELETE_SURROUNDING_TEXT_IN_CODE_POINTS: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT,

                        "InputConnection#deleteSurroundingTextInCodePoints");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "deleteSurroundingTextInCodePoints on inactive InputConnection");

                        return;

                    }

                    ic.deleteSurroundingTextInCodePoints(msg.arg1, msg.arg2);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_BEGIN_BATCH_EDIT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#beginBatchEdit");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "beginBatchEdit on inactive InputConnection");

                        return;

                    }

                    ic.beginBatchEdit();

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_END_BATCH_EDIT: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#endBatchEdit");

                try {

                    InputConnection ic = getInputConnection();

                    if (ic == null || !isActive()) {

                        Log.w(TAG, "endBatchEdit on inactive InputConnection");

                        return;

                    }

                    ic.endBatchEdit();

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_PERFORM_PRIVATE_COMMAND: {

                final SomeArgs args = (SomeArgs) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#performPrivateCommand");

                try {

                    final String action = (String) args.arg1;

                    final Bundle data = (Bundle) args.arg2;
@@ -547,11 +652,14 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                    }

                    ic.performPrivateCommand(action, data);

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                    args.recycle();

                }

                return;

            }

            case DO_REQUEST_UPDATE_CURSOR_ANCHOR_INFO: {

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#requestCursorUpdates");

                try {

                    final IIntResultCallback callback = (IIntResultCallback) msg.obj;

                    final InputConnection ic = getInputConnection();

                    final boolean result;
@@ -567,6 +675,9 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        Log.w(TAG, "Failed to return the result to requestCursorUpdates()."

                                + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_CLOSE_CONNECTION: {
@@ -577,6 +688,7 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                if (isFinished()) {

                    return;

                }

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#closeConnection");

                try {

                    InputConnection ic = getInputConnection();

                    // Note we do NOT check isActive() here, because this is safe
@@ -596,12 +708,14 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                        mInputConnection = null;

                        mFinished = true;

                    }

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                }

                return;

            }

            case DO_COMMIT_CONTENT: {

                final int flags = msg.arg1;

                SomeArgs args = (SomeArgs) msg.obj;

                Trace.traceBegin(Trace.TRACE_TAG_INPUT, "InputConnection#commitContent");

                try {

                    final IIntResultCallback callback = (IIntResultCallback) args.arg3;

                    final InputConnection ic = getInputConnection();
@@ -626,6 +740,7 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { 
                                + " result=" + result, e);

                    }

                } finally {

                    Trace.traceEnd(Trace.TRACE_TAG_INPUT);

                    args.recycle();

                }

                return;