Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bba370ec authored by Edgar Wang's avatar Edgar Wang
Browse files

Fine tune Widget library 

- rename resource in FooterPreference
- use material_grey_600 in MainSwitchBar directly
- backward compitable in MainSwitchBar
- correct dialog background and accent color

Bug: 191267392
Test: robotest & manual
Change-Id: I31fff1b157ec757e9f74f4b82ae8d997a0a117f1
parent 4f0d02b4

packages/SettingsLib/FooterPreference/src/com/android/settingslib/widget/FooterPreference.java

+1 −1
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ public class FooterPreference extends Preference { 
    private void init() {

        setLayoutResource(R.layout.preference_footer);

        if (getIcon() == null) {

            setIcon(R.drawable.ic_info_outline_24);

            setIcon(R.drawable.settingslib_ic_info_outline_24);

        }

        setOrder(ORDER_FOOTER);

        if (TextUtils.isEmpty(getKey())) {

packages/SettingsLib/MainSwitchPreference/res/values/colors.xml

+0 −1
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 
  -->



<resources xmlns:androidprv="http://schemas.android.com/apk/prv/res/android">

    <color name="settingslib_switchbar_background_color">@*android:color/material_grey_600</color>

    <color name="settingslib_switchbar_switch_track_tint">#BFFFFFFF</color>

    <color name="settingslib_switchbar_switch_thumb_tint">@android:color/white</color>

</resources>

packages/SettingsLib/MainSwitchPreference/src/com/android/settingslib/widget/MainSwitchBar.java

+10 −9
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ public class MainSwitchBar extends LinearLayout implements CompoundButton.OnChec 
            final TypedArray a = context.obtainStyledAttributes(

                    new int[]{android.R.attr.colorAccent});

            mBackgroundActivatedColor = a.getColor(0, 0);

            mBackgroundColor = context.getColor(R.color.settingslib_switchbar_background_color);

            mBackgroundColor = context.getColor(R.color.material_grey_600);

            a.recycle();

        }
@@ -88,11 +88,12 @@ public class MainSwitchBar extends LinearLayout implements CompoundButton.OnChec 
        mFrameView = findViewById(R.id.frame);

        mTextView = (TextView) findViewById(R.id.switch_text);

        mSwitch = (Switch) findViewById(android.R.id.switch_widget);

        if (BuildCompat.isAtLeastS()) {

            mBackgroundOn = getContext().getDrawable(R.drawable.settingslib_switch_bar_bg_on);

            mBackgroundOff = getContext().getDrawable(R.drawable.settingslib_switch_bar_bg_off);

            mBackgroundDisabled = getContext().getDrawable(

                    R.drawable.settingslib_switch_bar_bg_disabled);



        }

        addOnSwitchChangeListener((switchView, isChecked) -> setChecked(isChecked));



        setChecked(mSwitch.isChecked());
@@ -194,10 +195,8 @@ public class MainSwitchBar extends LinearLayout implements CompoundButton.OnChec 
     * Remove a listener for switch changes

     */

    public void removeOnSwitchChangeListener(OnMainSwitchChangeListener listener) {

        if (mSwitchChangeListeners.contains(listener)) {

        mSwitchChangeListeners.remove(listener);

    }

    }



    /**

     * Enable or disable the text and switch.
@@ -267,10 +266,12 @@ public class MainSwitchBar extends LinearLayout implements CompoundButton.OnChec 


        public static final Parcelable.Creator<SavedState> CREATOR =

                new Parcelable.Creator<SavedState>() {

                    @Override

                    public SavedState createFromParcel(Parcel in) {

                        return new SavedState(in);

                    }



                    @Override

                    public SavedState[] newArray(int size) {

                        return new SavedState[size];

                    }

packages/SettingsLib/SettingsTheme/res/values-v31/colors.xml

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
    <!-- Dialog accent color -->

    <color name="settingslib_dialog_accent">@android:color/system_accent1_600</color>

    <!-- Dialog background color -->

    <color name="settingslib_dialog_background">@android:color/system_neutral1_800</color>

    <color name="settingslib_dialog_background">@*android:color/surface_light</color>

    <!-- Dialog error color. -->

    <color name="settingslib_dialog_colorError">#d93025</color> <!-- Red 600 -->