Merge "Use WeakReference#refersTo() when possible" (bb563d8c) · Commits · e / os / android_frameworks_base

core/java/android/view/inputmethod/InputMethodManager.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -897,7 +897,7 @@ public final class InputMethodManager {

		return mServedInputConnection != null
		&& mServedInputConnection.isActive()
		&& mServedInputConnection.getServedView() == view;
		&& mServedInputConnection.isAssociatedWith(view);
		}
		}

+17 −1

Original line number	Diff line number	Diff line
		@@ -218,10 +218,26 @@ final class RemoteInputConnectionImpl extends IRemoteInputConnection.Stub {
		return mParentInputMethodManager.isActive() && !isFinished();
		}

		public View getServedView() {
		private View getServedView() {
		return mServedView.get();
		}

		/**
		* Queries if the given {@link View} is associated with this {@link RemoteInputConnectionImpl}
		* or not.
		*
		* @param view {@link View}.
		* @return {@code true} if the given {@link View} is not null and is associated with this
		* {@link RemoteInputConnectionImpl}.
		*/
		@AnyThread
		public boolean isAssociatedWith(@Nullable View view) {
		if (view == null) {
		return false;
		}
		return mServedView.refersTo(view);
		}

		/**
		* Gets and resets {@link #mHasPendingImmediateCursorAnchorInfoUpdate}.
		*