Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bae00621 authored by burakov's avatar burakov
Browse files

[flexiglass] Force garbage collection after successful authentication. 

This reverts commit 10f024bb.

Reason for revert: unit test passes.

Fix: 308826153
Test: Unit tests pass.
Flag: ACONFIG com.android.systemui.scene_container DEVELOPMENT
Change-Id: Ie097ae15f5308a6b0cc1e62e5eaac0c347a4a039
parent 565c5325

packages/SystemUI/src/com/android/systemui/authentication/domain/interactor/AuthenticationInteractor.kt

+21 −0
Original line number Diff line number Diff line
@@ -30,11 +30,16 @@ import com.android.systemui.authentication.shared.model.AuthenticationWipeModel 
import com.android.systemui.authentication.shared.model.AuthenticationWipeModel.WipeTarget

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dagger.qualifiers.Background

import com.android.systemui.user.domain.interactor.SelectedUserInteractor

import com.android.systemui.util.time.SystemClock

import javax.inject.Inject

import kotlin.math.max

import kotlin.time.Duration

import kotlin.time.Duration.Companion.seconds

import kotlinx.coroutines.CoroutineDispatcher

import kotlinx.coroutines.CoroutineScope

import kotlinx.coroutines.delay

import kotlinx.coroutines.flow.Flow

import kotlinx.coroutines.flow.MutableSharedFlow

import kotlinx.coroutines.flow.SharedFlow
@@ -44,6 +49,7 @@ import kotlinx.coroutines.flow.asSharedFlow 
import kotlinx.coroutines.flow.combine

import kotlinx.coroutines.flow.map

import kotlinx.coroutines.flow.stateIn

import kotlinx.coroutines.launch



/**

 * Hosts application business logic related to user authentication.
@@ -57,6 +63,7 @@ class AuthenticationInteractor 
@Inject

constructor(

    @Application private val applicationScope: CoroutineScope,

    @Background private val backgroundDispatcher: CoroutineDispatcher,

    private val repository: AuthenticationRepository,

    private val selectedUserInteractor: SelectedUserInteractor,

) {
@@ -227,6 +234,11 @@ constructor( 
        if (authenticationResult.isSuccessful) {

            repository.reportAuthenticationAttempt(isSuccessful = true)

            _onAuthenticationResult.emit(true)



            // Force a garbage collection in an attempt to erase any credentials left in memory.

            // Do it after a 5-sec delay to avoid making the bouncer dismiss animation janky.

            initiateGarbageCollection(delay = 5.seconds)



            return AuthenticationResult.SUCCEEDED

        }
@@ -312,6 +324,15 @@ constructor( 
        }

    }



    private suspend fun initiateGarbageCollection(delay: Duration) {

        applicationScope.launch(backgroundDispatcher) {

            delay(delay)

            System.gc()

            System.runFinalization()

            System.gc()

        }

    }



    companion object {

        const val TAG = "AuthenticationInteractor"

    }

packages/SystemUI/tests/utils/src/com/android/systemui/authentication/domain/interactor/AuthenticationInteractorKosmos.kt

+2 −0
Original line number Diff line number Diff line
@@ -19,12 +19,14 @@ package com.android.systemui.authentication.domain.interactor 
import com.android.systemui.authentication.data.repository.authenticationRepository

import com.android.systemui.kosmos.Kosmos

import com.android.systemui.kosmos.applicationCoroutineScope

import com.android.systemui.kosmos.testDispatcher

import com.android.systemui.user.domain.interactor.selectedUserInteractor



val Kosmos.authenticationInteractor by

    Kosmos.Fixture {

        AuthenticationInteractor(

            applicationScope = applicationCoroutineScope,

            backgroundDispatcher = testDispatcher,

            repository = authenticationRepository,

            selectedUserInteractor = selectedUserInteractor,

        )