Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba0dd8a7 authored by Chiachang Wang's avatar Chiachang Wang
Browse files

Dump only NORMAL priority information if no priority assigned 

The legacy design of "dumpsys connectivity" will only dump
information with NORMAL priority. It was updated to provide
both NORMAL and HIGH priority information in order to support
dump in bugreport. However, it will also affect the result
using dumpsys connectivity.

Update design to dump NORMAL priority only to align with legacy
design.

Bug: 188387185
Test: adb shell dumpsys connectivity
Test: adb bugreport and check the result in bugreport
Change-Id: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7
Merged-In: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7
parent 63fd7215

packages/Connectivity/service/src/com/android/server/ConnectivityService.java

+2 −6
Original line number Diff line number Diff line
@@ -1045,14 +1045,10 @@ public class ConnectivityService extends IConnectivityManager.Stub 
            } else {

                // ConnectivityService publishes binder service using publishBinderService() with

                // no priority assigned will be treated as NORMAL priority. Dumpsys does not send

                // "--dump-priority" arguments to the service. Thus, dump both NORMAL and HIGH to

                // align the legacy design.

                // "--dump-priority" arguments to the service. Thus, dump NORMAL only to align the

                // legacy output for dumpsys connectivity.

                // TODO: Integrate into signal dump.

                dumpNormal(fd, pw, args);

                pw.println();

                pw.println("DUMP OF SERVICE HIGH connectivity");

                pw.println();

                dumpHigh(fd, pw);

            }

        }

    }