Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9e6e0b5 authored by Makoto Onuki's avatar Makoto Onuki
Browse files

Make constructor "boring" in dashboard

Bug: 402797626
Test: ./scripts/ravenwood-stats-collector.sh
Flag: EXEMPT host tool change only
Change-Id: I3e75b0b4b567ac2da7e773dc1d204aa5855889d0
parent 5234819d
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ collect_apis() {
    echo "API CVS created at $out$desc"
}

collect_apis $apis " (import it as 'ravenwood_supported_apis2')"
collect_apis $apis " (import it as 'ravenwood_supported_apis3')"

cp *keep_all.txt $keep_all_dir
echo "Keep all files created at:"
+8 −2
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ class ApiDumper(
     */
    fun dump() {
        pw.printf("PackageName,ClassName,Inherited,DeclareClass,MethodName,MethodDesc" +
                ",Supported,Policy,Reason,Boring\n")
                ",Supported,Policy,Reason,Boring,StatsLabelValue\n")

        classes.forEach { classNode ->
            shownMethods.clear()
@@ -73,7 +73,7 @@ class ApiDumper(
        methodPolicy: FilterPolicyWithReason,
    ) {
        pw.printf(
            "%s,%s,%d,%s,%s,%s,%d,%s,%s,%d\n",
            "%s,%s,%d,%s,%s,%s,%d,%s,%s,%d,%d\n",
            csvEscape(classPackage),
            csvEscape(className),
            if (isSuperClass) { 1 } else { 0 },
@@ -84,6 +84,7 @@ class ApiDumper(
            methodPolicy.policy,
            csvEscape(methodPolicy.reason),
            if (computedMethodLabel == StatsLabel.SupportedButBoring) { 1 } else { 0 },
            computedMethodLabel.statValue,
        )
    }

@@ -130,6 +131,11 @@ class ApiDumper(
            return StatsLabel.SupportedButBoring
        }

        // Mark ctors and clinits as boring.
        when (mn.name) {
            CTOR_NAME, CLASS_INITIALIZER_NAME -> return StatsLabel.SupportedButBoring
        }

        return methodPolicy.statsLabel
    }

+0 −2
Original line number Diff line number Diff line
@@ -36,8 +36,6 @@ class HostStubGen(val options: HostStubGenOptions) {
        // Load all classes.
        val allClasses = ClassNodes.loadClassStructures(inJar, options.inJar.get)

//        val stats = HostStubGenStats(allClasses)

        // Dump the classes, if specified.
        options.inputJarDumpFile.ifSet {
            log.iTime("Dump file created at $it") {