Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9dccf5a authored by Jeff DeCew's avatar Jeff DeCew
Browse files

Let CallStyle notifications be any height. 

This separate dimension was really a bug waiting to happen. Add a little padding here or there, forget to update this dimension, and suddenly in rare cases the UI would be cropped.

Bug: 179178086
Test: Post CallStyle notifications with title, text, progress, smart actions.
Change-Id: I35500885eb53750fa2ccde4f2f602e6cfdb02113
parent 1a7ae5b9

packages/SystemUI/res/values/dimens.xml

+0 −4
Original line number Diff line number Diff line
@@ -167,10 +167,6 @@ 
         and the notification won't use this much, but is measured with wrap_content -->

    <dimen name="notification_messaging_actions_min_height">196dp</dimen>



    <!-- Height of a call notification. Note that this is an upper bound

     and the notification won't use this much, but is measured with wrap_content -->

    <dimen name="call_notification_full_height">172dp</dimen>



    <!-- a threshold in dp per second that is considered fast scrolling -->

    <dimen name="scroll_fast_threshold">1500dp</dimen>

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java

+1 −4
Original line number Diff line number Diff line
@@ -166,7 +166,6 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 
    private int mMaxSmallHeightLarge;

    private int mMaxSmallHeightMedia;

    private int mMaxExpandedHeight;

    private int mMaxCallHeight;

    private int mIncreasedPaddingBetweenElements;

    private int mNotificationLaunchHeight;

    private boolean mMustStayOnScreen;
@@ -687,7 +686,7 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 
            //  them a headerless design, then remove this hack.

            smallHeight = mMaxSmallHeightLarge;

        } else if (isCallLayout) {

            smallHeight = mMaxCallHeight;

            smallHeight = mMaxExpandedHeight;

        } else if (mUseIncreasedCollapsedHeight && layout == mPrivateLayout) {

            smallHeight = mMaxSmallHeightLarge;

        } else {
@@ -1621,8 +1620,6 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 
                R.dimen.notification_min_height_media);

        mMaxExpandedHeight = NotificationUtils.getFontScaledHeight(mContext,

                R.dimen.notification_max_height);

        mMaxCallHeight = NotificationUtils.getFontScaledHeight(mContext,

                R.dimen.call_notification_full_height);

        mMaxHeadsUpHeightBeforeN = NotificationUtils.getFontScaledHeight(mContext,

                R.dimen.notification_max_heads_up_height_legacy);

        mMaxHeadsUpHeightBeforeP = NotificationUtils.getFontScaledHeight(mContext,

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/wrapper/NotificationCallTemplateViewWrapper.kt

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ class NotificationCallTemplateViewWrapper constructor( 
) : NotificationTemplateViewWrapper(ctx, view, row) {



    private val minHeightWithActions: Int =

            NotificationUtils.getFontScaledHeight(ctx, R.dimen.call_notification_full_height)

            NotificationUtils.getFontScaledHeight(ctx, R.dimen.notification_max_height)

    private val callLayout: CallLayout = view as CallLayout



    private lateinit var conversationIconView: CachingIconView