Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b88aaa33 authored by Arpan Kaphle's avatar Arpan Kaphle Committed by Android (Google) Code Review
Browse files

Merge "Collecting origin in logging system" into udc-dev

parents 638885c6 8af68ce3

services/credentials/java/com/android/server/credentials/CreateRequestSession.java

+2 −0
Original line number Diff line number Diff line
@@ -61,6 +61,8 @@ public final class CreateRequestSession extends RequestSession<CreateCredentialR 
        super(context, sessionCallback, lock, userId, callingUid, request, callback,

                RequestInfo.TYPE_CREATE,

                callingAppInfo, enabledProviders, cancellationSignal, startedTimestamp);

        mRequestSessionMetric.collectCreateFlowInitialMetricInfo(

                /*origin=*/request.getOrigin() != null);

    }



    /**

services/credentials/java/com/android/server/credentials/GetRequestSession.java

+2 −1
Original line number Diff line number Diff line
@@ -59,7 +59,8 @@ public class GetRequestSession extends RequestSession<GetCredentialRequest, 
        int numTypes = (request.getCredentialOptions().stream()

                .map(CredentialOption::getType).collect(

                        Collectors.toSet())).size(); // Dedupe type strings

        mRequestSessionMetric.collectGetFlowInitialMetricInfo(numTypes);

        mRequestSessionMetric.collectGetFlowInitialMetricInfo(numTypes,

                /*origin=*/request.getOrigin() != null);

    }



    /**

services/credentials/java/com/android/server/credentials/MetricUtilities.java

+2 −0
Original line number Diff line number Diff line
@@ -287,6 +287,8 @@ public class MetricUtilities { 
                    /* count_credential_request_classtypes */

                    initialPhaseMetric.getCountRequestClassType()

                    // TODO(b/271135048) - add total count of request options

                    // TODO(b/271135048) - Uncomment once built past PWG review -

                    // initialPhaseMetric.isOriginSpecified()

            );

        } catch (Exception e) {

            Log.w(TAG, "Unexpected error during metric logging: " + e);

services/credentials/java/com/android/server/credentials/PrepareGetRequestSession.java

+2 −1
Original line number Diff line number Diff line
@@ -59,7 +59,8 @@ public class PrepareGetRequestSession extends GetRequestSession { 
        int numTypes = (request.getCredentialOptions().stream()

                .map(CredentialOption::getType).collect(

                        Collectors.toSet())).size(); // Dedupe type strings

        mRequestSessionMetric.collectGetFlowInitialMetricInfo(numTypes);

        mRequestSessionMetric.collectGetFlowInitialMetricInfo(numTypes,

                /*origin=*/request.getOrigin() != null);

        mPrepareGetCredentialCallback = prepareGetCredentialCallback;

    }

services/credentials/java/com/android/server/credentials/metrics/InitialPhaseMetric.java

+12 −0
Original line number Diff line number Diff line
@@ -42,6 +42,10 @@ public class InitialPhaseMetric { 
    // over to the next latency object.

    private long mCredentialServiceBeginQueryTimeNanoseconds = -1;



    // Indicates if the origin was specified when making this API request

    // TODO(b/271135048) - Emit once metrics approved

    private boolean mOriginSpecified = false;





    public InitialPhaseMetric() {

    }
@@ -115,4 +119,12 @@ public class InitialPhaseMetric { 
    public int getCountRequestClassType() {

        return mCountRequestClassType;

    }



    public void setOriginSpecified(boolean originSpecified) {

        mOriginSpecified = originSpecified;

    }



    public boolean isOriginSpecified() {

        return mOriginSpecified;

    }

}